Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torch.func jacobian OOM #186

Closed
wiseodd opened this issue May 16, 2024 · 2 comments · Fixed by #202
Closed

torch.func jacobian OOM #186

wiseodd opened this issue May 16, 2024 · 2 comments · Fixed by #202
Assignees
@wiseodd
Labels
bug Something isn't working
Milestone
0.2

Comments

@wiseodd
Copy link
Collaborator

wiseodd commented May 16, 2024 •
edited
Loading

Minimum example to get this error:
https://gist.github.com/wiseodd/b29973cd96f96f3af620ca131571eaa4

Fix:

use AsdlGGN backend and then in _glm_predictive_distribution (in baselaplace.py), use:

Js, f_mu = self.backend.jacobians(X)

instead of:

Js, f_mu = self.backend.functorch_jacobians(X)
@wiseodd wiseodd added the bug Something isn't working label May 16, 2024
@wiseodd wiseodd self-assigned this May 16, 2024
@wiseodd
Copy link
Collaborator Author

wiseodd commented May 16, 2024

I think this is because: pytorch/functorch#1058

@wiseodd wiseodd mentioned this issue May 16, 2024
Merged
@wiseodd wiseodd added this to the 0.2 milestone Jun 15, 2024
@wiseodd wiseodd linked a pull request Jul 6, 2024 that will close this issue
Caveats #202
Merged
@wiseodd
Copy link
Collaborator Author

wiseodd commented Jul 6, 2024

Users will be warned for now via #202. Ultimately, this shall be solved by #203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wiseodd wiseodd

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

Caveats aleximmer/Laplace
1 participant
@wiseodd