Skip to content

Commit dd1a50a

Browse files
authored
[Bugfix][Minor] Make ignore_eos effective (vllm-project#4468)
1 parent 715c2d8 commit dd1a50a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

vllm/sampling_params.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,8 @@ def update_from_generation_config(
275275
self, generation_config: Dict[str, Any]) -> None:
276276
"""Update if there are non-default values from generation_config"""
277277
# Update eos_token_id for generation
278-
if eos_ids := generation_config.get("eos_token_id"):
278+
if (not self.ignore_eos) and (eos_ids :=
279+
generation_config.get("eos_token_id")):
279280
# it can be either int or list of int
280281
if isinstance(eos_ids, int):
281282
eos_ids = [eos_ids]

0 commit comments

Comments
 (0)