Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent coding style #96

Open
alexrudd2 opened this issue Oct 4, 2023 · 2 comments
Open

Consistent coding style #96

alexrudd2 opened this issue Oct 4, 2023 · 2 comments

Comments

@alexrudd2
Copy link
Owner

npm run lint and npm run format should produce a consisent result.

@jedahan
Copy link
Collaborator

jedahan commented Oct 6, 2023

I'm waiting for all the functional PRs to be merged or closed before submitting a format PR.

@jedahan
Copy link
Collaborator

jedahan commented Oct 18, 2023

I started a branch ts-standard that

  • adopts ts-standard as a zero-config linter and formatter
  • sets the tsconfig to strict: true
  • adds a git pre-push hook that runs npm test && npm run lint
  • sets the local repository hooks directory to githooks after any npm run build

I am slowly working my way through all the issues, which mostly are explicit return types, a dozen or so cases of not handling nulls/undefineds, a few removals of any types, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants