-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not work on Catalina 10.15.2 #50
Comments
+1 |
same here...Maybe this will help Thread 2 Crashed:: Dispatch queue: NSOperationQueue 0x7fb1980405e0 (QOS: UNSPECIFIED) |
+1 |
I can successfully edit "DarkAquaAppearance.car" but not "SystemAppearance.car". ThemeEngine crashes when I want to edit SystemAppearance. |
I tried with the update to 10.15.3 beta but it didn't solve. |
Maybe same situation, just force closed. I don't know if it's helpful. Thread 3 crashed with X86 Thread State (64-bit): |
Same here it Crash |
I tried to compile, but get an error... Build target ThemeEngine of project ThemeEngine with configuration Debug @MUI68K anyway to get your build? |
Can you write an e-mail to [email protected]? I don't know if I can share directly here when I've changed actual code and not just building it directly from source with no change. I will provide a link that you can download from then. |
has somebody found a fix? |
I don't know if my build of ThemeEngine is a fix, but it does work and as a far as being a fix - I fixed it for me and those who contacted me hasn't returned with a complaint that it doesn't work. The code that I suggest cutting away is in the ThemeKit portion - but it's easiest to find when you build ThemeEngine from existing source and ThemeEngine then crashes upon opening SystemAppearance.car - the string I suggest is highlighted as being an error. That's how I initially played around with what I wrote earlier. |
@ MUI68K, |
Please post here a working app |
@chris1111 And everyone. Link taken down because the latest fork of ThemeEngine available here Works on macOS Catalina and macOS Big Sur too. There's a description here https://github.com/jslegendre/ThemeEngine on how to edit and replace themes on Big Sur. |
Thanks its work 👍🏻 |
You mean something like this?
So that means that the whole rest of the function should always be skipped? Why should it then be called at all? |
Thank you, I have tried it. It does not crash, but it shows some really weird behaviour: When editing a .car file, the list of resources in the middle column will always scroll to the bottom by itself when the window is in foreground. That makes it pretty useless for editing. Any idea why and how to fix it? |
I can't answer that - I have however looked into this issue as bugs me too. Initially I just wanted the application to function again by opening and saving .car files. |
Thank you, I have contacted the author of that patch to find out how exactly he fixed it (the PR is not mergable because it contains lots of other changes made by XCode that don't fit to what is in the repository).
Yeah, that's how I was able to get productive, too. However it is still unnecessary trouble. And I would still really like to find out what the underlying problem for the crash is. |
Okay, so I've made the scrolling stop and added Affinity Photo export capability. Importing from Affinity Photo isn't happening at the moment.
Okay, so I've made the scrolling stop and added Affinity Photo export capability. Importing from Affinity Photo isn't happening at the moment. Shoot me an email if you would like to take a look. I will explain what I did in a seperate comment if can backtrace the steps properly. |
Cool. Can you send me your patch? If you are not familiar with using git and creating pull requests, you might just (in a terminal window) run the following: |
If only that command worked.. I mean,,, I'm only greeted with the options for git diff And, I am not all comfortable with using git - because I fuck up I think - |
You're inside the ThemeEngine directory cloned from github? |
Yes,, I am inside the main cloned (copy) of the downloaded repository - not within the ThemeEngine folder within that folder... is that the trick? |
And then just attach that file to your next comment. I'll do the rest :) |
I think I have problems because I'm working locally and not using the Github program. Can I import what I have done and import that to the Github app for better getting that command to work? |
which one do I stay in? I don't think I'm dumb, but there's no content in the output because the diff fails |
I won't be able to look into this before this evening. Take your time to check everything, based on my code. Then send me another patch if you find an issue to fix. |
won't be necessary as your repo is functioning just fine - I forgot I was still using my hacky version of ThemeEngine. I just tried compiling yours 💯 Also, I thought of this - could one not include a /build folder within the repo that has the compiled version of that current repo already in there for the user to download from right here instead of having to make use of external links such as Google Drive and Jumpshare for the older revisions(in my case) ? I've seen other authors do this. |
The github way would be to upload releases separately. I briefly thought about this yesterday, but then decided otherwise, because what we are doing here is totally inofficial. Also there is the signature issue, anything I produce will be without a trusted signature, so that people will not be able to run it straight away. Before putting out a release I would really like to have some clarity who is in charge, or, better, whether @alexzielenski will eventually integrate PRs and create a release. |
@MUI68K I have tried out the Affinity export feature. The import back into ThemeEngine is based on two AppleScript files which currently support the Adobe tools. I don't know the Adobe tools and hence cannot really guess how much of the code in the two scripts is more or less generic or specific to the Adobe software. Looks like we're going to need help here. As it is now things are a bit subobtimal: I guess one should either make the choice (Affinity or Adobe) configurable or just plain stupid make both available through the menu. However, as mentioned, importing from Affinity is missing and should really be added. |
Sure, I can see why this is the better approach - after all this isn't an official build - I guess we'll know soon enough how this all pans out.
This I've also thought about - making the Send To Affinity - menuitem. I wouldn't know how to do that - the days before was just getting around that scroll issue and such - perhaps the change to using the original AppleScripts is on order, I've read that Serif does consider implementing - but the thread I read begain in 2018 or there abouts and is still ongoing. I have yet to properly figure this out. |
Thank you, @MUI68K! I have now followed your proposal and restored the old export/import functionality for the Adobe tools. The old binary is still downloadable, the new one can be downloaded here: https://drive.google.com/open?id=1PZzU7Bbo_-0Tc6LS8XUq9jYFb5dW_Kyd The code in my repo (and in PR #54) now reflects the new binary. If somebody wants to play around with the Affinity import/export, here's the commit to start with: |
You are amazing. |
@mbert is there a way that one could in Xcode see what sort of stuff ThemeEngine outputs on a given change? It's in order to fix the misalignment of the Finder buttons for one. The version of ThemeEngine OS X El Capitan didn't have these issues where a change to the exact Finder toolbar button would make all buttons simply go POOF! Like they never wanted to be there in the first place. |
Not quite understand whether I understand you correctly. Just in general terms: There is an option for the target operating system version when you build ThemeEngine. This should be able to make the resulting binary compatible to older OSX versions. However the result will most certainly differ from a ThemeEngine version built with an older version of XCode on an older OSX version. Also I guess you want something like a preview on the .car file produced, right? I think that is a functionality that one will need to create explicitly. And I'm afraid I don't have much of a clue of MacOS programming, so I won't be much of a help here. |
Oh,, well. 'm going to have to try some things on my own - to see if they work or not. I am used to so much replacing of .car files that I think I can replace a bit more-- poor SSD |
I know this is weird, but can someone upload the Mojave version of xcode, I can't download anymore since I downgraded but I can't download it from the apple page either because appearantly I am too young |
Theme Engine no longer receives from Photoshop. I don't know why it only receives if you run GUI (/Applications/ThemeEngine.app/Contents/MacOS/ThemeEngine) Can someone explain to me please? |
If you downloaded the most recent build - after the scrolling was fixed - you might also notice that that particular version was with an experimental Affinity export option. It never did receive from any Affinity application. I'm only mentioning this in case you have that version - because it broke the Photoshop "Send To" and "Receive From" I would urge you to compile the latest that @mbert has put up on his fork of ThemeEngine as this was reverted to using Photoshop and Illustrator functions. Otherwise, I'm unsure what is going on. It might not be that everything I personally fiddled with was reverted properly. |
Yes, I have tried with that git version and also with the two that he put in this chat. But they have the same problem with affinity and photoshop. They send the file to edit but ThemeEngine doesn't receive it later. When I open the app via GUI with terminal it works. I think it is a temporary remedy. I'm in Catalina 10.15.4 by the way. |
I fixed it #57 |
#50: Fixes crash and scrolling issue on Catalina
appreciate if you can make the file still available man |
I think you might use the file I placed for download in this comment: ThemeEngine-pr54a.zip. |
Oh yeah, that's right - I forgot about that whole deal. I just assumed everyone was downloading the build from here: https://github.com/jslegendre/ThemeEngine/releases |
dead link :( |
Edited my original posting. There was no reason for me to keep it up seeing as the fixes issues that was most keeping ThemeEngine from opening and working on Catalina are now included in the link available through the URL below: |
Any news for Big Sur ? |
that url is dead too... |
Sorry about that -- I put the link inside URL code which isn't the correct way |
That looks really cool. Are you planning to release something? Regarding Big Sur - since I only have my "productive" machine I am a bit scared. Longing to read a bit more about experience people have made with theming Big Sur, pitfalls etc. |
It's early days still - I only have this one Mac too to work with - although I am not using it for anything productive as such. edit No, I don't plan on releasing anything for Big Sur - it's too much of a task. It could be that theming Big Sur gets better in the future, but for now I am running on empty and despite having the desire to theme macOS - there's just not enough in it for me at this point. |
At the moment I'm using MacOS Monterey, it sucks without the gorgeous traffic lights. Same was when I used Big Sur. It's very unfortunate that you aren't going to release for Big Sur or Monterey. I've tried lots but nothing seems to work for me on Monterey. The only mod Was successful with was cDock beta for Monterey. I really hope you release for Big Sur or Monterey. |
You need to download a port done by Jeremy legendre (https://github.com/jslegendre/ThemeEngine). It works fine on Monterey and Big Sur. |
worked perfectly on 10.15.1, after upgrading to 10.15.2 crashed, Someone with the same problem?
The text was updated successfully, but these errors were encountered: