Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting column with null freezes #251

Open
croo opened this issue Jun 23, 2016 · 2 comments
Open

Sorting column with null freezes #251

croo opened this issue Jun 23, 2016 · 2 comments

Comments

@croo
Copy link

croo commented Jun 23, 2016

Hi!

Column sorting fails when null value exists in a column.
The console error: TypeError: bAttr is null

and the label "Processing..." is shown on the center of the table.

My dynatable setup:

$.dynatableSetup({
        features: {
            paginate: false,
            sort: true,
            pushState: false,
            search: false,
            recordCount: true,
            perPageSelect: false
        }
    });

cheers (awesome lib btw)

@dnsBlah
Copy link

dnsBlah commented Jul 6, 2016

please give a little mockup of your table.
p.s. it's sorting: true, not sort: true

@andrewrohde
Copy link

andrewrohde commented Nov 7, 2016

The problem is the call toLowerCase on aAttr and bAttr where it's possible for either one to be null.
I've submitted a pull request that solves this issue. #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants