From ad45633ca246c0df34f26c9f647945cee53b6e0f Mon Sep 17 00:00:00 2001 From: Theodore Brown Date: Fri, 14 Mar 2014 12:08:21 -0500 Subject: [PATCH 1/2] Only call Array.sort() if sort columns/keys are specified Fixes issue #87 --- jquery.dynatable.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/jquery.dynatable.js b/jquery.dynatable.js index d08aba3..4d35b7c 100644 --- a/jquery.dynatable.js +++ b/jquery.dynatable.js @@ -643,7 +643,11 @@ return comparison; } - return sort.call(settings.dataset.records, sortFunction); + if (sortsKeys.length > 0 || !$.isEmptyObject(sorts)) { + return sort.call(settings.dataset.records, sortFunction); + } else { + return settings.dataset.records; + } }; this.paginate = function() { From 4a3c198f84217cf67d298e73f34675ba0e3cf746 Mon Sep 17 00:00:00 2001 From: Theodore Brown Date: Fri, 23 May 2014 16:16:41 -0500 Subject: [PATCH 2/2] Remove unnecessary sort() returns --- jquery.dynatable.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/jquery.dynatable.js b/jquery.dynatable.js index 4d35b7c..9412b24 100644 --- a/jquery.dynatable.js +++ b/jquery.dynatable.js @@ -644,9 +644,7 @@ } if (sortsKeys.length > 0 || !$.isEmptyObject(sorts)) { - return sort.call(settings.dataset.records, sortFunction); - } else { - return settings.dataset.records; + sort.call(settings.dataset.records, sortFunction); } };