From 5b203435bf4e6e97f3c591af66e8c68f1a6de7d5 Mon Sep 17 00:00:00 2001 From: Marcus Asteborg Date: Fri, 10 Jan 2025 08:19:50 -0800 Subject: [PATCH] Fix clippy::needless_as_bytes --- src/io/stun.rs | 6 +++--- src/rtp/ext.rs | 6 +++--- src/rtp/rtcp/sdes.rs | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/io/stun.rs b/src/io/stun.rs index 2014ddf0..1a27e4ff 100644 --- a/src/io/stun.rs +++ b/src/io/stun.rs @@ -525,7 +525,7 @@ impl<'a> Attributes<'a> { let username = self .username .map(|v| { - let pad = 4 - (v.as_bytes().len() % 4) % 4; + let pad = 4 - (v.len() % 4) % 4; ATTR_TLV_LENGTH + v.len() + pad }) .unwrap_or_default(); @@ -557,9 +557,9 @@ impl<'a> Attributes<'a> { fn to_bytes(self, vec: &mut dyn Write, trans_id: &[u8]) -> io::Result<()> { if let Some(v) = self.username { vec.write_all(&Self::USERNAME.to_be_bytes())?; - vec.write_all(&(v.as_bytes().len() as u16).to_be_bytes())?; + vec.write_all(&(v.len() as u16).to_be_bytes())?; vec.write_all(v.as_bytes())?; - let pad = 4 - (v.as_bytes().len() % 4) % 4; + let pad = 4 - (v.len() % 4) % 4; for _ in 0..pad { vec.write_all(&[0])?; } diff --git a/src/rtp/ext.rs b/src/rtp/ext.rs index 48bf0739..505570a4 100644 --- a/src/rtp/ext.rs +++ b/src/rtp/ext.rs @@ -683,19 +683,19 @@ impl Extension { } RtpStreamId => { let v = ev.rid?; - let l = v.as_bytes().len(); + let l = v.len(); buf[..l].copy_from_slice(v.as_bytes()); Some(l) } RepairedRtpStreamId => { let v = ev.rid_repair?; - let l = v.as_bytes().len(); + let l = v.len(); buf[..l].copy_from_slice(v.as_bytes()); Some(l) } RtpMid => { let v = ev.mid?; - let l = v.as_bytes().len(); + let l = v.len(); buf[..l].copy_from_slice(v.as_bytes()); Some(l) } diff --git a/src/rtp/rtcp/sdes.rs b/src/rtp/rtcp/sdes.rs index 5455297a..bb834ffa 100644 --- a/src/rtp/rtcp/sdes.rs +++ b/src/rtp/rtcp/sdes.rs @@ -126,7 +126,7 @@ impl WordSized for Sdes { .values .iter() // 2 here for 2 byte encoding of type + length - .map(|(_, s)| 2 + s.as_bytes().len()) + .map(|(_, s)| 2 + s.len()) .sum::(); let padded = pad_bytes_to_word(byte_size);