Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retryable error doesn't increment connection timeout number #440

Open
nunomaduro opened this issue Jul 23, 2019 · 0 comments
Open

retryable error doesn't increment connection timeout number #440

nunomaduro opened this issue Jul 23, 2019 · 0 comments
Labels

Comments

@nunomaduro
Copy link

Looking at the retry specs, we see that:

When retrying, use the next host in your array.
When retrying because of a timeout, raise the timeouts like this:
number_of_tries * base_timeout
Example: Search (5s timeout) → Search timeout → Search (10s timeout) → Repeat.

At the moment, on the Python API Client we don't use yet the retry_count for this.

Goal:

  1. Multiple timeouts by the number of tries on the line

    request = Request(verb.upper(), request_options.headers, data,
    .

  2. Add a test on it.

Implementation on C#: https://github.com/algolia/algoliasearch-client-csharp/blob/42ab1842f859df87482602b12d5cb714bfa8ec71/src/Algolia.Search/Transport/HttpTransport.cs#L118

@nunomaduro nunomaduro added the Bug label Jul 23, 2019
@nunomaduro nunomaduro changed the title Retryable error doesn't increment connection timeout number retryable error doesn't increment connection timeout number Jun 4, 2020
shortcuts added a commit that referenced this issue Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant