Skip to content

fix(perf): don't render loading icon if not visible #6694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix(perf): don't render loading icon if not visible #6694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e752ff
fix(perf): don't render loading icon if not visible
Haroenv Sep 2, 2025
9e05b65
tests
Haroenv Sep 2, 2025
a8b30c1
vue
Haroenv Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions ...rch.js/src/components/RefinementList/__tests__/__snapshots__/RefinementList-test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,6 @@ exports[`RefinementList rendering with facets from search 1`] = `
>
reset
</button>
<span
class="loadingIndicator"
hidden=""
>
loadingIndicator
</span>
</form>
</div>
</div>
Expand Down Expand Up @@ -201,12 +195,6 @@ exports[`RefinementList rendering without facets from search 1`] = `
>
reset
</button>
<span
class="loadingIndicator"
hidden=""
>
loadingIndicator
</span>
</form>
</div>
</div>
Expand Down
3 changes: 1 addition & 2 deletions packages/instantsearch.js/src/components/SearchBox/SearchBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,13 +231,12 @@ class SearchBox extends Component<
data={{ cssClasses }}
/>

{showLoadingIndicator && (
{showLoadingIndicator && isSearchStalled && (
<Template
templateKey="loadingIndicator"
rootTagName="span"
rootProps={{
className: cssClasses.loadingIndicator,
hidden: !isSearchStalled,
}}
templates={templates}
data={{ cssClasses }}
Expand Down
161 changes: 0 additions & 161 deletions packages/instantsearch.js/src/widgets/refinement-list/__tests__/refinement-list.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,49 +174,6 @@ describe('refinementList', () => {
/>
</svg>
</button>
<span
class="ais-SearchBox-loadingIndicator SEARCHABLE-LOADING-INDICATOR"
hidden=""
>
<svg
aria-hidden="true"
aria-label="Results are loading"
class="ais-SearchBox-loadingIcon SEARCHABLE-LOADING-ICON"
height="16"
stroke="#444"
viewBox="0 0 38 38"
width="16"
>
<g
fill="none"
fill-rule="evenodd"
>
<g
stroke-width="2"
transform="translate(1 1)"
>
<circle
cx="18"
cy="18"
r="18"
stroke-opacity=".5"
/>
<path
d="M36 18c0-9.94-8.06-18-18-18"
>
<animatetransform
attributeName="transform"
dur="1s"
from="0 18 18"
repeatCount="indefinite"
to="360 18 18"
type="rotate"
/>
</path>
</g>
</g>
</svg>
</span>
</form>
</div>
</div>
Expand Down Expand Up @@ -423,49 +380,6 @@ describe('refinementList', () => {
/>
</svg>
</button>
<span
class="ais-SearchBox-loadingIndicator"
hidden=""
>
<svg
aria-hidden="true"
aria-label="Results are loading"
class="ais-SearchBox-loadingIcon"
height="16"
stroke="#444"
viewBox="0 0 38 38"
width="16"
>
<g
fill="none"
fill-rule="evenodd"
>
<g
stroke-width="2"
transform="translate(1 1)"
>
<circle
cx="18"
cy="18"
r="18"
stroke-opacity=".5"
/>
<path
d="M36 18c0-9.94-8.06-18-18-18"
>
<animatetransform
attributeName="transform"
dur="1s"
from="0 18 18"
repeatCount="indefinite"
to="360 18 18"
type="rotate"
/>
</path>
</g>
</g>
</svg>
</span>
</form>
</div>
</div>
Expand Down Expand Up @@ -609,49 +523,6 @@ describe('refinementList', () => {
/>
</svg>
</button>
<span
class="ais-SearchBox-loadingIndicator"
hidden=""
>
<svg
aria-hidden="true"
aria-label="Results are loading"
class="ais-SearchBox-loadingIcon"
height="16"
stroke="#444"
viewBox="0 0 38 38"
width="16"
>
<g
fill="none"
fill-rule="evenodd"
>
<g
stroke-width="2"
transform="translate(1 1)"
>
<circle
cx="18"
cy="18"
r="18"
stroke-opacity=".5"
/>
<path
d="M36 18c0-9.94-8.06-18-18-18"
>
<animatetransform
attributeName="transform"
dur="1s"
from="0 18 18"
repeatCount="indefinite"
to="360 18 18"
type="rotate"
/>
</path>
</g>
</g>
</svg>
</span>
</form>
</div>
</div>
Expand Down Expand Up @@ -769,14 +640,6 @@ describe('refinementList', () => {
Reset
</span>
</button>
<span
class="ais-SearchBox-loadingIndicator"
hidden=""
>
<span>
Loading
</span>
</span>
</form>
</div>
</div>
Expand Down Expand Up @@ -889,14 +752,6 @@ describe('refinementList', () => {
Reset
</span>
</button>
<span
class="ais-SearchBox-loadingIndicator"
hidden=""
>
<span>
Loading
</span>
</span>
</form>
</div>
</div>
Expand Down Expand Up @@ -1018,14 +873,6 @@ describe('refinementList', () => {
Reset
</span>
</button>
<span
class="ais-SearchBox-loadingIndicator"
hidden=""
>
<span>
Loading
</span>
</span>
</form>
</div>
</div>
Expand Down Expand Up @@ -1138,14 +985,6 @@ describe('refinementList', () => {
Reset
</span>
</button>
<span
class="ais-SearchBox-loadingIndicator"
hidden=""
>
<span>
Loading
</span>
</span>
</form>
</div>
</div>
Expand Down
69 changes: 0 additions & 69 deletions packages/instantsearch.js/src/widgets/search-box/__tests__/search-box.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ describe('searchBox', () => {
expect(container.querySelector('.ais-SearchBox-input')).toHaveClass(
'INPUT'
);
expect(container.querySelector('.ais-SearchBox-loadingIcon')).toHaveClass(
'LOADING_ICON'
);
expect(
container.querySelector('.ais-SearchBox-loadingIndicator')
).toHaveClass('LOADING_INDICATOR');
expect(container.querySelector('.ais-SearchBox-resetIcon')).toHaveClass(
'RESET_ICON'
);
Expand Down Expand Up @@ -158,49 +152,6 @@ describe('searchBox', () => {
/>
</svg>
</button>
<span
class="ais-SearchBox-loadingIndicator"
hidden=""
>
<svg
aria-hidden="true"
aria-label="Results are loading"
class="ais-SearchBox-loadingIcon"
height="16"
stroke="#444"
viewBox="0 0 38 38"
width="16"
>
<g
fill="none"
fill-rule="evenodd"
>
<g
stroke-width="2"
transform="translate(1 1)"
>
<circle
cx="18"
cy="18"
r="18"
stroke-opacity=".5"
/>
<path
d="M36 18c0-9.94-8.06-18-18-18"
>
<animatetransform
attributeName="transform"
dur="1s"
from="0 18 18"
repeatCount="indefinite"
to="360 18 18"
type="rotate"
/>
</path>
</g>
</g>
</svg>
</span>
</form>
</div>
</div>
Expand Down Expand Up @@ -279,16 +230,6 @@ describe('searchBox', () => {
Reset
</span>
</button>
<span
class="ais-SearchBox-loadingIndicator"
hidden=""
>
<span
class="ais-SearchBox-loadingIcon"
>
Wait…
</span>
</span>
</form>
</div>
</div>
Expand Down Expand Up @@ -367,16 +308,6 @@ describe('searchBox', () => {
Reset
</span>
</button>
<span
class="ais-SearchBox-loadingIndicator"
hidden=""
>
<span
class="ais-SearchBox-loadingIcon"
>
Wait…
</span>
</span>
</form>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-instantsearch/src/ui/SearchBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export function SearchBox({
)}
hidden={!isSearchStalled}
>
<LoadingIcon classNames={classNames} />
{isSearchStalled && <LoadingIcon classNames={classNames} />}
</span>
</form>
</div>
Expand Down
Loading