Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React-Native #779

Closed
Eric-Warehime opened this issue May 11, 2023 · 2 comments
Closed

Support React-Native #779

Eric-Warehime opened this issue May 11, 2023 · 2 comments
Labels
new-feature-request Feature request that needs triage Team Lamprey

Comments

@Eric-Warehime
Copy link
Contributor

Problem

Let's support running the SDK in react-native. There are a few issues which are known that I'll try to list below, and probably a bunch of things that might break.
#738
#643 (although this one in particular looks fixed)
Others?

Dependencies

N/A

Urgency

3.0.0 release

@Eric-Warehime Eric-Warehime added the new-feature-request Feature request that needs triage label May 11, 2023
@algoanne
Copy link

The tweetnacl package uses some functions that are not provided in React Native. There is a React Native-specific tweetnacl package that fixes this somehow, so we may wish to switch to that instead. Or we could polyfill?

Moving crypto dependencies is delicate and we are not JS experts. Work TBD.

@Eric-Warehime
Copy link
Contributor Author

Attempts at polyfilling crypto for react-native resulted in both a huge amount of needed code changes, and more importantly having to pull in all of react-native as a dependency because it's listed as a peer-dependency. This made our webpack build more complex because of wanting to remove it, and also caused failures when running w/ CJS because it seems like react-native is only compatible with ES for some reason.

I've opened #798 to give users more visibility into failures in react-native when they do hit them, but at this point they will need to polyfill crypto themselves unless react-native decides to implement it in their core modules.

@algoanne algoanne closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature-request Feature request that needs triage Team Lamprey
Projects
None yet
Development

No branches or pull requests

3 participants
@Eric-Warehime @algoanne and others