Fix theme-switching UI issues in navbar and footer (fixes #776) - #802
Fix theme-switching UI issues in navbar and footer (fixes #776)#802GeethaBurigalla wants to merge 1 commit into
Conversation
✅ Deploy Preview for astounding-nougat-da0f6a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@GeethaBurigalla is attempting to deploy a commit to the adityapaul2603-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe footer’s bottom ribbon now uses theme-aware border and text classes. The desktop GitHub navbar link receives adjusted padding and sizing classes, with its URL and behavior unchanged. ChangesUI styling updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello maintainer, PR is ready please review and approve the deployment. |
Pull Request Summary
fix: align navbar GitHub button and fix footer theme colors (#776)
What changed?
Two theme-switching UI fixes from issue #776: (1) the GitHub button in the navbar now uses the same
px-6 py-2padding as the Sign In button next to it, fixing the visual misalignment between the two; (2) the footer's bottom ribbon ("Asymptotic Scales" section) now uses the existingtheme-borderandtheme-text-mutedutility classes instead of hardcodedborder-slate-800/text-slate-400, so it correctly adapts when switching from dark to light theme. Files affected:src/components/Navbar.jsx,src/components/Footer.jsx.Why is this needed?
Closes #776
The issue reported four problems. This PR addresses #1 (GitHub/Sign In button misalignment) and #3 (footer colors not adapting to light theme). Items #2 (bottom bar staying dark) and #4 (window-control dots turning white) both trace to
HeroProductPreview.jsx, which appears to be an intentional dark "code editor" style mockup with no theme variants anywhere in the component — rather than guess at an unscoped redesign, I've left those two for maintainer input (see notes below).Type of Change
feat- New user-facing feature or algorithm capabilityfix- Bug fix or regression fixdocs- Documentation-only changestyle- Formatting or styling change with no behavior changerefactor- Code restructuring with no feature or bug-fix behavior changeperf- Performance improvementtest- Test coverage or test infrastructure changebuild- Build system, dependency, or packaging changeci- GitHub Actions, Docker, Vercel, or release automation changechore- Maintenance change that does not affect usersrevert- Reverts a previous changeRelease Notes
Release note category:
Release note entry:
Testing and Verification
npm ciornpm installnpm run format:checknpm run lintnpm run buildhttp://localhost:5173Skipped or additional testing notes:
npm run buildand responsive testing not yet run — will add before merge if requested.npm run format:checknot run directly, but affected files were formatted withnpx prettier --write.UI Evidence
Before:
(navbar GitHub button shorter than Sign In button; footer ribbon border/text hardcoded to dark-theme slate colors even in light mode)
After:
(GitHub and Sign In buttons same height/padding; footer ribbon border and text adapt to the active theme)
CI/CD and Deployment Impact
Deployment notes:
Follow-up needed: issue #776 also mentions (2) a bottom bar staying dark-themed and (4) window-control dots turning white — both appear to live in
HeroProductPreview.jsx, which has no theme variants at all (looks like an intentional dark IDE-style mockup). Left out of this PR pending maintainer confirmation on whether that panel should become theme-aware or stay fixed-dark by design.Reviewer Checklist
Summary by CodeRabbit