refactor code

Author: aliazmoodehvaldi

Diff for: CHANGELOG/1.x/CHANGELOG.md

@@ -1,6 +1,12 @@
 Change Log
 ==========
 
+## Version 1.0.5
+
+2022-11-04
+
+ * Refactor code
+ 
 ## Version 1.0.4
 
 2022-09-21

Diff for: lib/util/Utilities.js

@@ -27,13 +27,13 @@ module.exports = {
     },
 
     isDefined(data) {
-        return typeof data !== 'undefined' || data !== undefined;
+        return !data;
     },
 
     isUnDefined(arr) {
         let lengthOfDefinedObject = 0;
         arr.forEach(item => {
-            let isUndefined = typeof item === 'undefined' || item === undefined;
+            let isUndefined = !item;
             if (!isUndefined)
                 lengthOfDefinedObject++;
         });

Diff for: lib/validation/index.js

@@ -268,8 +268,9 @@ function getNumberForListOfItem(arr) {
         lengthOfItem = () => arrayOBoolean.length;
 
     arr.forEach(item => {
-        if (item?.length !== 0 && item !== '' && (typeof item !== 'undefined' && item !== undefined && item !== 'undefined'))
-            arrayOBoolean.push(true);
+        if (!item)
+            return;
+        arrayOBoolean.push(true);
     });
 
     return lengthOfItem();

Diff for: package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "openrtp",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "Is a text-based software framework supported by an extensive ecosystem of tools that help developers design, build, document, and use programming relationships for socket.io.",
   "main": "index.js",
   "scripts": {

Diff for: package.json

@@ -7,9 +7,9 @@ let {
 
 
 module.exports = (port, host, route) => {
-    let hostName = host === undefined ? '127.0.0.1' : host,
-        portNumber = port === undefined ? 17892 : port,
-        viewRoute = route === undefined ? '/socket-docs' : route,
+    let hostName = !host ? '127.0.0.1' : host,
+        portNumber = !port ? 17892 : port,
+        viewRoute = !route ? '/socket-docs' : route,
         path = __dirname + '/../../lib/ui/public';
     app.use('/public', express.static(path));
     app.get(viewRoute, reqHandler);

Diff for: src/express/index.js

@@ -39,6 +39,7 @@ function securityDefinitions() {
     let securityDefinitionsObject = yamlObject?.securityDefinitions;
     module.exports.arrayOfKeyForAddAuthInAllRequest = [];
     module.exports.securityDefinitions = [];
+
     for (let key in securityDefinitionsObject) {
         let item = securityDefinitionsObject[key];
 
@@ -50,8 +51,8 @@ function securityDefinitions() {
 }
 
 function paths() {
-    let data = [];
     let pathsObject = yamlObject?.paths;
+
     if (isArray(pathsObject)) {
         pathsObject.forEach(object => {
             jsonConfig('/', object);
@@ -95,16 +96,14 @@ function jsonConfig(key, object) {
         let isUsedArgs = args !== undefined;
 
 
-        if (isArray(itemForParameter?.$ref)) {
-            itemForParameter.$ref.forEach(item => {
+        if (isArray(itemForParameter?.$ref))
+           return  itemForParameter.$ref.forEach(item => {
 
                 let isRefObject = isRefInComponent(item, COMPONENTS_FOR_PARAMETERS_OBJECT_NAME);
                 if (isRefObject)
                     newParameterArr = newParameterArr.concat(isRefObject);
 
             });
-            return;
-        }
 
         let isRefObject = isRefInComponent(itemForParameter, COMPONENTS_FOR_PARAMETERS_OBJECT_NAME);
         if (isRefObject)
@@ -145,9 +144,9 @@ function jsonConfig(key, object) {
 
     });
 
-    if (isDefined(object?.parameters)) {
+    if (isDefined(object?.parameters))
         object.parameters = newParameterArr;
-    }
+
 
     let newEventArr = [];
 
@@ -163,19 +162,18 @@ function jsonConfig(key, object) {
 
         if (isRef(eventObject) && isString(eventObject)) {
             let isRefObject = isRefInComponent(eventObject, COMPONENTS_FOR_EVENTS_OBJECT_NAME);
-            if (isRefObject) {
+            if (isRefObject)
                 newEventArr = newEventArr.concat(isRefObject);
-            }
         }
 
         if (!isRef(eventObject))
             newEventArr = newEventArr.concat(eventObject);
 
     });
 
-    if (isDefined(object?.events)) {
+    if (isDefined(object?.events))
         object.events = newEventArr;
-    }
+
 
 }
 
@@ -188,7 +186,7 @@ function isReferenceIntoComponentObjectForParameter(key, type) {
     let parameters = yamlObject?.components[type],
         parameterObject = parameters?.[getRefName(key)];
 
-    return parameterObject === undefined ? false : parameterObject;
+    return !parameterObject ? false : parameterObject;
 }