Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Support #26

Open
ammoradi opened this issue Apr 18, 2020 · 1 comment
Open

Typescript Support #26

ammoradi opened this issue Apr 18, 2020 · 1 comment

Comments

@ammoradi
Copy link

Thanks for this lib.
but it seems there isn't any type definition for typescript types because when I use dayjs.calendar(...):

Property 'calendar' does not exist on type 'typeof import(".../node_modules/dayjs/index.d.ts")'.

I think you should extend the default dayjs's type definitions.

@always-maap
Copy link

Full TS support was impossible by the authors because of the dayjs type design. My PR to dayjs was accepted a few weeks ago and will be in the next version. I started maintaining this repo and move to our Org with the same API and full TS support.

https://github.com/zoomit-org/Dayjs-Jalali-Plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants