Skip to content

Conversation

@liulx20
Copy link
Collaborator

@liulx20 liulx20 commented Jun 26, 2025

as titled.

@liulx20 liulx20 requested a review from Copilot June 26, 2025 08:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses bugs in the get_v operation and refines the edge expand logic by updating how label triplets are processed and modifying error handling.

  • In edge expand, label filtering now selectively populates the labels based on provided tables and direction.
  • In get_v, the error branch for mismatched output vertex labels now constructs a valid context using a builder rather than returning a bad request error.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
flex/engines/graph_db/runtime/execute/ops/retrieve/edge.cc Updated label filtering logic based on tables and direction
flex/engines/graph_db/runtime/common/operators/retrieve/get_v.h Changed error handling behavior and added a new branch for single-label processing
Comments suppressed due to low confidence (2)

flex/engines/graph_db/runtime/execute/ops/retrieve/edge.cc:646

  • When filtering labels based on the provided tables and direction, if none of the labels meet the criteria, eep.labels may be empty even if the original parsed labels (temps) are non-empty. Consider adding a fallback to assign 'temps' when no labels are selected to preserve expected behavior.
      for (auto& label : temps) {

flex/engines/graph_db/runtime/common/operators/retrieve/get_v.h:202

  • The error handling change for an output vertex label mismatch now returns a context built from a builder instead of returning a bad request error. Confirm that this new behavior is intentional to avoid unexpected downstream processing.
          auto builder = SLVertexColumnBuilder::builder(output_vertex_label);

@github-actions github-actions bot added the stale label Jul 12, 2025
@github-actions
Copy link
Contributor

/cc @yecol @sighingnow, this issus/pr has had no activity for a long time, please help to review the status and assign people to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant