Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Flink Connector support pendingRecords metric #138

Open
1 of 2 tasks
wuchong opened this issue Dec 6, 2024 Discussed in #91 · 2 comments · May be fixed by #157
Open
1 of 2 tasks

[Feature] Flink Connector support pendingRecords metric #138

wuchong opened this issue Dec 6, 2024 Discussed in #91 · 2 comments · May be fixed by #157
Assignees
Labels
component=flink feature New feature or request good first issue Good for newcomers

Comments

@wuchong
Copy link
Member

wuchong commented Dec 6, 2024

Originally posted by luoyuxia November 28, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

Although we has coverd most of standard metrics defined in FLIP-33: Standardize Connector Metrics, we still miss the metrics of pendingRecords which help us to trace data backlog.

Solution

pending records = latest log offset - fetched log offset.

For snapshot read phase of primary key table, it should be total records in kv snapshot - records emited, but to simplify, we can just trace the phase of incremental reading which read from change log.

Anything else?

No response

Willingness to contribute

  • I'm willing to submit a PR!
@wuchong wuchong added feature New feature or request good first issue Good for newcomers component=flink labels Dec 6, 2024
@wuchong
Copy link
Member Author

wuchong commented Dec 9, 2024

@Alibaba-HZY asked to contribute this ticket in the original discussion #91
@Alibaba-HZY do you still want to contribute?

@Alibaba-HZY
Copy link

@Alibaba-HZY asked to contribute this ticket in the original discussion #91 @Alibaba-HZY do you still want to contribute?
yes, i've developed some code of this issue

Alibaba-HZY pushed a commit to Alibaba-HZY/fluss that referenced this issue Dec 10, 2024
Alibaba-HZY pushed a commit to Alibaba-HZY/fluss that referenced this issue Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component=flink feature New feature or request good first issue Good for newcomers
Projects
None yet
2 participants