Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stream response buffer issue #1703

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

cr7258
Copy link
Collaborator

@cr7258 cr7258 commented Jan 22, 2025

Ⅰ. Describe what this PR did

当前对于没有实现 OnStreamingResponseBody 方法的 provider,流式请求会被错误地进行缓存,等待接收完所有的流式请求后才会一起返回给客户端。

Ⅱ. Does this pull request fix one issue?

fixes #1699

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@cr7258 cr7258 requested review from CH3CHO and rinfx as code owners January 22, 2025 03:24
@cr7258 cr7258 requested a review from johnlanni January 22, 2025 03:24
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 133a30b into alibaba:main Jan 22, 2025
8 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.61%. Comparing base (ef31e09) to head (e0743c5).
Report is 280 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1703      +/-   ##
==========================================
+ Coverage   35.91%   43.61%   +7.70%     
==========================================
  Files          69       76       +7     
  Lines       11576    12358     +782     
==========================================
+ Hits         4157     5390    +1233     
+ Misses       7104     6630     -474     
- Partials      315      338      +23     

see 70 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI代理流式请求接口返回慢
3 participants