Skip to content

optimize plugin sdk#1930

Merged
johnlanni merged 4 commits intohigress-group:mainfrom
johnlanni:optimize-plugin-sdk
Mar 22, 2025
Merged

optimize plugin sdk#1930
johnlanni merged 4 commits intohigress-group:mainfrom
johnlanni:optimize-plugin-sdk

Conversation

@johnlanni
Copy link
Copy Markdown
Collaborator

Ⅰ. Describe what this PR did

Removed unnecessary log parameter passing

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.74%. Comparing base (ef31e09) to head (b4c7249).
Report is 365 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1930      +/-   ##
==========================================
+ Coverage   35.91%   43.74%   +7.83%     
==========================================
  Files          69       78       +9     
  Lines       11576    12479     +903     
==========================================
+ Hits         4157     5459    +1302     
+ Misses       7104     6678     -426     
- Partials      315      342      +27     

see 73 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@cr7258 cr7258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐉

@johnlanni johnlanni merged commit 45fbc8b into higress-group:main Mar 22, 2025
11 checks passed
VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
ISADBA pushed a commit to ISADBA/higress that referenced this pull request Jan 13, 2026
ISADBA pushed a commit to ISADBA/higress that referenced this pull request Jan 13, 2026
johnlanni added a commit that referenced this pull request Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants