Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2862 improve seata beanPostProcessor order #2875

Open
wants to merge 1 commit into
base: 2021.x
Choose a base branch
from

Conversation

zhuangzhuangdashen
Copy link

Describe what this PR does / why we need it

SeataBeanPostProcessor had better has a higher init order, for fare some beans be initialized early along with some business beanPostProcessor, in that situation, this bean will not be proxyed by Seata like SeataFeignClient.

Does this pull request fix one issue?

Fixed #2862

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


李壮壮 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.


/**
* @author xiaojing
*/
public class SeataBeanPostProcessor implements BeanPostProcessor {
public class SeataBeanPostProcessor implements BeanPostProcessor, Ordered {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加这个的含义在哪里,你们实际开发有用到吗

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们遇到的issue
https://q1rp72ja5q.feishu.cn/docx/EGqBd6GGboiFi4xyPxFcdy6rnwG

原因可以描述为:业务通过A开头的后置处理器间接实例化了FeignHttpClient,导致FeignHttpClient不会被seataBeanPostProcessor代理,这样的话FeignSeataClient就不生效,在feign调用中xid无法透传导致全局事务割裂。

因此建议可以提高下SeataBeanPostProcessor的优先级

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seata xid can't transmit if use httpclient
3 participants