From 9d8d3faa3d28e26e78a5102e2046fb47d1d8dd25 Mon Sep 17 00:00:00 2001
From: "Zezheng.Li" <Zezheng.Li@linux.alibaba.com>
Date: Thu, 21 Sep 2023 10:54:15 +0800
Subject: [PATCH] fix concept

---
 include/ylt/struct_pack/reflection.hpp | 31 ++++++++++++++++++++------
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/include/ylt/struct_pack/reflection.hpp b/include/ylt/struct_pack/reflection.hpp
index 1d41725d7..339c5ec2c 100644
--- a/include/ylt/struct_pack/reflection.hpp
+++ b/include/ylt/struct_pack/reflection.hpp
@@ -15,6 +15,7 @@
  */
 #pragma once
 #include <cstddef>
+#include <cstdint>
 #include <cstring>
 #include <limits>
 #include <set>
@@ -167,13 +168,6 @@ concept has_user_defined_id_ADL = requires {
                                   struct_pack_id((T*)nullptr)>;
 };
 
-
-template <typename T>
-concept is_base_class = requires (T* t){
-  std::is_same_v<uint32_t,decltype(t->get_struct_pack_id())>;
-  typename struct_pack::detail::derived_class_set_t<T>;
-};
-
 #else
 
 template <typename T, typename = void>
@@ -213,6 +207,29 @@ constexpr bool has_user_defined_id_ADL = has_user_defined_id_ADL_impl<T>::value;
 
 #endif
 
+
+
+#if __cpp_concepts >= 201907L
+template <typename T>
+concept is_base_class = requires (T* t) {
+  std::is_same_v<uint32_t,decltype(t->get_struct_pack_id())>;
+  typename struct_pack::detail::derived_class_set_t<T>;
+};
+#else
+template <typename T, typename = void>
+struct is_base_class_impl : std::false_type {};
+
+template <typename T>
+struct is_base_class_impl<
+    T, std::void_t<
+    std::enable_if<std::is_same_v<decltype(((T*)nullptr)->get_struct_pack_id()), uint32_t>>,
+    typename struct_pack::detail::derived_class_set_t<T>>>
+    : std::true_type {};
+template <typename T>
+constexpr bool is_base_class=is_base_class_impl<T>::value;
+
+#endif
+
 #if __cpp_concepts >= 201907L
   template <typename Type>
   concept deserialize_view = requires(Type container) {