Skip to content

Commit 97878f4

Browse files
dexpotaBerkmann18
authored andcommitted
fix: add contributions (#211)
* Fix issue #209 * Fix validation issue * Add myself to contributors list
1 parent a91145f commit 97878f4

File tree

3 files changed

+33
-11
lines changed

3 files changed

+33
-11
lines changed

.all-contributorsrc

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,6 +352,16 @@
352352
"contributions": [
353353
"code"
354354
]
355+
},
356+
{
357+
"login": "dexpota",
358+
"name": "Fabrizio",
359+
"avatar_url": "https://avatars1.githubusercontent.com/u/7031675?v=4",
360+
"profile": "https://www.destro.me",
361+
"contributions": [
362+
"bug",
363+
"code"
364+
]
355365
}
356366
]
357367
}

README.md

Lines changed: 22 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
22
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
33

4-
- [
5-
all-contributors-cli
6-
](#all-contributors-cli)
4+
- [ all-contributors-cli ](#all-contributors-cli)
75
- [The problem](#the-problem)
86
- [This solution](#this-solution)
97
- [Using the all-contributors-cli](#using-the-all-contributors-cli)
10-
- [Contributors](#contributors)
8+
- [Contributors](#contributors-)
119
- [LICENSE](#license)
1210

1311
<!-- END doctoc generated TOC please keep comment here to allow auto update -->
1412

15-
> [There is now a GitHub Bot](https://github.com/all-contributors/all-contributors-bot) for automating the maintenance of your contributors table ✨<br />Say goodbye to command line tool dependencies and hello to the [@all-contributors bot 🤖](https://github.com/all-contributors/all-contributors-bot)
13+
> [There is now a GitHub Bot](https://github.com/all-contributors/all-contributors-bot)
14+
> for automating the maintenance of your contributors table ✨<br />Say goodbye
15+
> to command line tool dependencies and hello to the
16+
> [@all-contributors bot 🤖](https://github.com/all-contributors/all-contributors-bot)
1617
1718
<h1 align="center">
1819
all-contributors-cli
@@ -46,13 +47,14 @@
4647
[![Code Coverage](https://img.shields.io/codecov/c/github/all-contributors/all-contributors-cli.svg)](https://codecov.io/github/all-contributors/all-contributors-cli)
4748
[![Version](https://img.shields.io/npm/v/all-contributors-cli.svg)](https://www.npmjs.com/package/all-contributors-cli)
4849
[![Downloads](https://img.shields.io/npm/dm/all-contributors-cli.svg)](http://www.npmtrends.com/all-contributors-cli)
49-
[![All Contributors](https://img.shields.io/badge/all_contributors-34-orange.svg?style=flat-square)](#contributors-)
50+
[![All Contributors](https://img.shields.io/badge/all_contributors-37-orange.svg?style=flat-square)](#contributors-)
5051
[![Star on Github](https://img.shields.io/github/stars/all-contributors/all-contributors-cli.svg?style=social)](https://github.com/all-contributors/all-contributors-cli/stargazers)
5152

5253
## The problem
5354

54-
You want to implement the [All Contributors](https://github.com/all-contributors/all-contributors) spec, but don't
55-
want to maintain the table by hand
55+
You want to implement the
56+
[All Contributors](https://github.com/all-contributors/all-contributors) spec,
57+
but don't want to maintain the table by hand
5658

5759
## This solution
5860

@@ -62,15 +64,19 @@ specification for your GitHub or GitLab repository.
6264

6365
## Using the all-contributors-cli
6466

65-
If you're looking to use the cli, head over to [the cli docs on allcontributors.org](https://allcontributors.org/docs/en/cli/overview). The all-contributors website contains all the information required to install, configure and use the all-contributors-cli.
67+
If you're looking to use the cli, head over to
68+
[the cli docs on allcontributors.org](https://allcontributors.org/docs/en/cli/overview).
69+
The all-contributors website contains all the information required to install,
70+
configure and use the all-contributors-cli.
6671

6772
## Contributors ✨
6873

6974
Thanks goes to these wonderful people
7075
([emoji key](https://allcontributors.org/docs/en/emoji-key)):
7176

7277
<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
73-
<!-- prettier-ignore -->
78+
<!-- prettier-ignore-start -->
79+
<!-- markdownlint-disable -->
7480
<table>
7581
<tr>
7682
<td align="center"><a href="https://github.com/jfmengels"><img src="https://avatars.githubusercontent.com/u/3869412?v=3" width="100px;" alt="Jeroen Engels"/><br /><sub><b>Jeroen Engels</b></sub></a><br /><a href="https://github.com/all-contributors/all-contributors-cli/commits?author=jfmengels" title="Code">💻</a> <a href="https://github.com/all-contributors/all-contributors-cli/commits?author=jfmengels" title="Documentation">📖</a> <a href="https://github.com/all-contributors/all-contributors-cli/commits?author=jfmengels" title="Tests">⚠️</a></td>
@@ -120,8 +126,14 @@ Thanks goes to these wonderful people
120126
<td align="center"><a href="https://github.com/simon300000"><img src="https://avatars1.githubusercontent.com/u/12656264?v=4" width="100px;" alt="simon3000"/><br /><sub><b>simon3000</b></sub></a><br /><a href="https://github.com/all-contributors/all-contributors-cli/commits?author=simon300000" title="Tests">⚠️</a></td>
121127
<td align="center"><a href="https://sno2wman.dev/"><img src="https://avatars3.githubusercontent.com/u/15155608?v=4" width="100px;" alt="SnO₂WMaN"/><br /><sub><b>SnO₂WMaN</b></sub></a><br /><a href="https://github.com/all-contributors/all-contributors-cli/commits?author=SnO2WMaN" title="Code">💻</a></td>
122128
</tr>
129+
<tr>
130+
<td align="center"><a href="https://www.destro.me"><img src="https://avatars1.githubusercontent.com/u/7031675?v=4" width="100px;" alt="Fabrizio"/><br /><sub><b>Fabrizio</b></sub></a><br /><a href="https://github.com/all-contributors/all-contributors-cli/issues?q=author%3Adexpota" title="Bug reports">🐛</a> <a href="https://github.com/all-contributors/all-contributors-cli/commits?author=dexpota" title="Code">💻</a></td>
131+
</tr>
123132
</table>
124133

134+
<!-- markdownlint-enable -->
135+
<!-- prettier-ignore-end -->
136+
125137
<!-- ALL-CONTRIBUTORS-LIST:END -->
126138

127139
This project follows the

src/cli.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function startGeneration(argv) {
7272
}
7373

7474
function addContribution(argv) {
75-
const username = String(argv._[1])
75+
const username = argv._[1] === undefined ? undefined : String(argv._[1])
7676
const contributions = argv._[2]
7777
// Add or update contributor in the config file
7878
return updateContributors(argv, username, contributions).then(data => {

0 commit comments

Comments
 (0)