Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate the get sentences API #47

Open
allan-simon opened this issue Jan 20, 2018 · 4 comments
Open

Paginate the get sentences API #47

allan-simon opened this issue Jan 20, 2018 · 4 comments
Assignees

Comments

@allan-simon
Copy link
Owner

use a "last_id" type of pagination

@jean553
Copy link
Collaborator

jean553 commented Jan 30, 2018

Should we do the same for GET /languages/{language_id}/sentences ?

@allan-simon
Copy link
Owner Author

yes , should be tracked by a separate issue I think

@jean553
Copy link
Collaborator

jean553 commented Jan 31, 2018

Is last_id optional ? In fact, Rocket does not handle optional query parameters. A PR has been provided a few weeks ago here rwf2/Rocket#454. Should we add a second route or simply require the last_id as a mandatory parameter, with a default value for the first page ?

@allan-simon
Copy link
Owner Author

by the way in an other API I've seen people using "starting_after_id=" for pagination, which i think was more "readable" than "last_id"

I should be optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants