-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task547_spl_translation_entk_en and task560_alt_translation_en_entk #589
Comments
@yeganehkordi The task is sentence translation and the task what usually does is convert given english sentence to it's tokens. But as tokens are also in english the input and output doesn't differ. Even I'm confused on this task. @swarooprm can you please look into it and help us. |
Yeah, except for punctuations, they seem to be the same. |
Yeah, "English tokens" is one of the translated versions in their data. I think we can drop these two tasks. @danyaljj |
Sounds good, thank you! |
Moving some of the comments from #709 to here: @yeganehkordi 's comment:
@Palipoor 's comment:
|
In my opinion, we could keep en_entk and entk_en tasks and mention in the definition that the task is to remove/add space before punctuation. This is a simple task, but not an invalid task. Let's not worry about how models are going to process it. E.g. even if the encoder ignores the space, the decoder has to decode it back with space. My opinion is not very strong and I am also fine if we decide to delete it. However, we should note that, creating a task requires significant effort, and deleting is easy. So, we should avoid deleting as much as possible and think about repairing. |
I think in the worst-case scenario, we can shuffle the tokens in the input and change these tasks to "order generation" tasks. |
The instruction is incomplete, and it seems the task is to remove the space before punctuation marks. @PhaniRohithaKaza Can you explain the tokens?
The text was updated successfully, but these errors were encountered: