From 623240c58fa4b2915c0dd141458c85db0f3fdb61 Mon Sep 17 00:00:00 2001 From: sjm41 Date: Thu, 4 Jun 2026 10:46:38 +0100 Subject: [PATCH 1/4] Make event_status and current_version optional on gene change events Override required: false via slot_usage on both GeneChangeEventSlotAnnotation and GeneChangeEventSlotAnnotationDTO (event_status_name / current_version). Co-Authored-By: Claude Opus 4.7 (1M context) --- model/schema/gene.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/model/schema/gene.yaml b/model/schema/gene.yaml index 46fbec2ba..ce33e3e9c 100644 --- a/model/schema/gene.yaml +++ b/model/schema/gene.yaml @@ -189,6 +189,10 @@ classes: slot_usage: single_gene: required: true + event_status: + required: false + current_version: + required: false acquires_in_merge: range: Gene merged_into: @@ -212,6 +216,10 @@ classes: slot_usage: gene_identifier: required: true + event_status_name: + required: false + current_version: + required: false GeneOntologyAnnotation: is_a: AuditedObject From faeba456bab792bd7ff9b098c4760d667357d446 Mon Sep 17 00:00:00 2001 From: GitHub Action Date: Thu, 4 Jun 2026 09:51:11 +0000 Subject: [PATCH 2/4] Automated artifacts regeneration [skip actions] --- .../jsonschema/allianceModel.schema.json | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/generated/jsonschema/allianceModel.schema.json b/generated/jsonschema/allianceModel.schema.json index 13ecf5dce..0ed1856c5 100644 --- a/generated/jsonschema/allianceModel.schema.json +++ b/generated/jsonschema/allianceModel.schema.json @@ -22205,7 +22205,10 @@ }, "current_version": { "description": "The current version of the entity, generated by this nomenclature event. It starts at one, and is incremented by one with every major change.", - "type": "integer" + "type": [ + "integer", + "null" + ] }, "date_created": { "description": "The date on which an entity was created. This can be applied to nodes or edges.", @@ -22241,7 +22244,10 @@ }, "event_status": { "description": "Status for an event change: provisional or approved.", - "type": "string" + "type": [ + "string", + "null" + ] }, "event_type": { "description": "Category of major change event for an entity.", @@ -22352,8 +22358,6 @@ "required": [ "single_gene", "event_type", - "event_status", - "current_version", "internal" ], "title": "GeneChangeEventSlotAnnotation", @@ -22382,7 +22386,10 @@ }, "current_version": { "description": "The current version of the entity, generated by this nomenclature event. It starts at one, and is incremented by one with every major change.", - "type": "integer" + "type": [ + "integer", + "null" + ] }, "date_created": { "description": "The date on which an entity was created. This can be applied to nodes or edges.", @@ -22418,7 +22425,10 @@ }, "event_status_name": { "description": "Name of the VocabularyTerm describing the status of an event change: provisional or approved.", - "type": "string" + "type": [ + "string", + "null" + ] }, "event_type_name": { "description": "Name of the VocabularyTerm describing the category of major change event for an entity.", @@ -22521,8 +22531,6 @@ "required": [ "gene_identifier", "event_type_name", - "event_status_name", - "current_version", "internal" ], "title": "GeneChangeEventSlotAnnotationDTO", From 14f9ee079df12ede374bccb81808768ad91500a9 Mon Sep 17 00:00:00 2001 From: sjm41 Date: Thu, 4 Jun 2026 10:57:12 +0100 Subject: [PATCH 3/4] Move event_status / current_version optionality to abstract parents Per follow-up review, apply the required: false override on the abstract ChangeEventSlotAnnotation and ChangeEventSlotAnnotationDTO classes via slot_usage, rather than on the gene-specific child classes. Removes the now-redundant overrides from GeneChangeEventSlotAnnotation and GeneChangeEventSlotAnnotationDTO. Co-Authored-By: Claude Opus 4.7 (1M context) --- model/schema/core.yaml | 10 ++++++++++ model/schema/gene.yaml | 8 -------- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/model/schema/core.yaml b/model/schema/core.yaml index 0830b499e..512831a2f 100644 --- a/model/schema/core.yaml +++ b/model/schema/core.yaml @@ -411,6 +411,11 @@ classes: - symbol_renamed_from - full_name_renamed_to - full_name_renamed_from + slot_usage: + event_status: + required: false + current_version: + required: false ChangeEventSlotAnnotationDTO: is_a: SlotAnnotationDTO @@ -431,6 +436,11 @@ classes: - symbol_renamed_from - full_name_renamed_to - full_name_renamed_from + slot_usage: + event_status_name: + required: false + current_version: + required: false Association: is_a: AuditedObject diff --git a/model/schema/gene.yaml b/model/schema/gene.yaml index ce33e3e9c..46fbec2ba 100644 --- a/model/schema/gene.yaml +++ b/model/schema/gene.yaml @@ -189,10 +189,6 @@ classes: slot_usage: single_gene: required: true - event_status: - required: false - current_version: - required: false acquires_in_merge: range: Gene merged_into: @@ -216,10 +212,6 @@ classes: slot_usage: gene_identifier: required: true - event_status_name: - required: false - current_version: - required: false GeneOntologyAnnotation: is_a: AuditedObject From 283e7841f4a24ada022abaf895b62b5cc0b58d40 Mon Sep 17 00:00:00 2001 From: Chris Grove Date: Thu, 4 Jun 2026 09:07:25 -0400 Subject: [PATCH 4/4] Remove requirements in slot definitions --- model/schema/core.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/model/schema/core.yaml b/model/schema/core.yaml index 512831a2f..dc45aa329 100644 --- a/model/schema/core.yaml +++ b/model/schema/core.yaml @@ -1106,7 +1106,6 @@ slots: Status for an event change: provisional or approved. range: VocabularyTerm multivalued: false - required: true event_status_name: description: >- @@ -1114,7 +1113,6 @@ slots: provisional or approved. range: string multivalued: false - required: true current_version: description: >- @@ -1122,7 +1120,6 @@ slots: It starts at one, and is incremented by one with every major change. range: integer multivalued: false - required: true acquires_in_merge: description: >-