Fix reputer/worker window boundaries, tests added (#771)

<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
v           ✰  Thanks for creating a PR! You're awesome! ✰
v Please note that maintainers will only review those PRs with a
completed PR template.
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >  -->

## Purpose of Changes and their Description
* Fix: Reputer remainder lag incorrectly computed.
* Alignment of inclusiveness (all inclusive, consistent in both reputer
and worker windows) so as to remove confusion.
* Overflow protection.
* Redundant check removed on worker submission window at `EndBlocker`.
* Exhaustive unit tests for both windows

## Link(s) to Ticket(s) or Issue(s) resolved by this PR

## Are these changes tested and documented?

- [x] If tested, please describe how. If not, why tests are not needed. 
✅  Added new unit tests
✅ Ran all tests and integration tests
- [x] If documented, please describe where. If not, describe why docs
are not needed. -- Added `Data Submission` section to `./README.md`.
- [x] Added to `Unreleased` section of `CHANGELOG.md`?

---------

Signed-off-by: Diego C <[email protected]>
Co-authored-by: Arnaud Mimart <[email protected]>

Author: xmariachi

.gitignore

@@ -54,3 +54,5 @@ test/fuzz/.config.json
 
 allora.log
 
+**/__debug*
+

CHANGELOG.md

@@ -80,6 +80,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * [#757](https://github.com/allora-network/allora-chain/pull/757) Incoming value limiting
 * [#761](https://github.com/allora-network/allora-chain/pull/761) Fix close worker nonce boundaries
 * [#760](https://github.com/allora-network/allora-chain/pull/760) Fix topic low-weight inactive topic weight vulnerability
+* [#771](https://github.com/allora-network/allora-chain/pull/771) Fix reputer/worker window boundaries
 
 ### Security
 

README.md

@@ -347,8 +347,17 @@ ssh -NL 2345:localhost:2345 [email protected]
 
 9- At Cursor, go to the debug pannel, pick "Remote Debug" configuration and start debugging.
 
+## Data Submission Windows
 
-### References
+Data is submitted by workers and reputers within the allowed submission windows.
+
+For workers, the submission window is defined at the topic level, as the blocks starting at `nonce.BlockHeight` and ending at `nonce.BlockHeight + topic.WorkerSubmissionWindow`. 
+
+For reputers, the submission window starts at `(nonce.BlockHeight + topic.GroundTruthLag)` and it lasts 1 `topic.EpochLength` + any remaining additional lag until end of epoch, only applying when `topic.GroundTruthLag` and `topic.EpochLength` are not multiples, and calculated as `(topic.EpochLength - (topic.GroundTruthLag % topic.EpochLength))`.
+
+Both windows are inclusive of start and end boundaries.
+
+## References
 
 - https://github.com/go-delve/delve/blob/master/Documentation/faq.md#remote
 - https://www.jetbrains.com/help/go/attach-to-running-go-processes-with-debugger.html#attach-to-a-process-on-a-remote-machine

x/emissions/keeper/keeper.go

@@ -3995,20 +3995,6 @@ func (k *Keeper) PruneReputerNonces(ctx context.Context, topicId uint64, blockHe
 	return nil
 }
 
-// Return true if the nonce is within the worker submission window for the topic
-// Inclusive of the start block height and exclusive of the end block height
-func (k *Keeper) BlockWithinWorkerSubmissionWindowOfNonce(topic types.Topic, nonce types.Nonce, blockHeight int64) bool {
-	return nonce.BlockHeight <= blockHeight && blockHeight < topic.WorkerSubmissionWindow+nonce.BlockHeight
-}
-
-// Return true if the nonce is within the worker submission window for the topic
-// Inclusive of the start block height and of the end block height
-func (k *Keeper) BlockWithinReputerSubmissionWindowOfNonce(topic types.Topic, nonce types.ReputerRequestNonce, blockHeight int64) bool {
-	extraLag := topic.GroundTruthLag % topic.EpochLength
-	return nonce.ReputerNonce.BlockHeight+topic.GroundTruthLag <= blockHeight &&
-		blockHeight <= nonce.ReputerNonce.BlockHeight+topic.GroundTruthLag+topic.EpochLength+extraLag
-}
-
 func (k *Keeper) ValidateStringIsBech32(actor ActorId) error {
 	_, err := sdk.AccAddressFromBech32(actor)
 	if err != nil {