From 4bf4385ebf7f35729dfdd4f96c3e10da44be58e0 Mon Sep 17 00:00:00 2001 From: Philipp Zettl Date: Mon, 26 Aug 2019 14:09:03 +0200 Subject: [PATCH 1/2] SUP-8350: Extend the empty Link-Check for checking "https://" --- src/plugins/extra/emptylink/css/emptylink.css | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/plugins/extra/emptylink/css/emptylink.css b/src/plugins/extra/emptylink/css/emptylink.css index ab2b330b28..fb766ca284 100644 --- a/src/plugins/extra/emptylink/css/emptylink.css +++ b/src/plugins/extra/emptylink/css/emptylink.css @@ -1,16 +1,18 @@ /* mark all anchor elements without name and href attribute */ .aloha-editable.aloha-emptylink-plugin a:not([name]):not([href]), -/* mark all anchor elements with empty href attribute (including '#') and the name and data-gentics-aloha-object-id attributes not set */ + /* mark all anchor elements with empty href attribute (including '#') and the name and data-gentics-aloha-object-id attributes not set */ .aloha-editable.aloha-emptylink-plugin a[href='#']:not([name]):not([data-gentics-aloha-object-id]), .aloha-editable.aloha-emptylink-plugin a[href='']:not([name]):not([data-gentics-aloha-object-id]), .aloha-editable.aloha-emptylink-plugin a[href='http://']:not([name]):not([data-gentics-aloha-object-id]), -/* mark all anchor elements with empty name attribute and the href attribute not set */ +.aloha-editable.aloha-emptylink-plugin a[href='https://']:not([name]):not([data-gentics-aloha-object-id]), + /* mark all anchor elements with empty name attribute and the href attribute not set */ .aloha-editable.aloha-emptylink-plugin a[name='']:not([href]), -/* mark all anchor elements with empty href (including '#') and empty name attribute */ + /* mark all anchor elements with empty href (including '#') and empty name attribute */ .aloha-editable.aloha-emptylink-plugin a[href='#'][name=''], .aloha-editable.aloha-emptylink-plugin a[href='http://'][name=''], +.aloha-editable.aloha-emptylink-plugin a[href='https://'][name=''], .aloha-editable.aloha-emptylink-plugin a[href=''][name=''], -/* mark all anchor elements that are marked to link to offline data-gentics-aloha-objects */ + /* mark all anchor elements that are marked to link to offline data-gentics-aloha-objects */ .aloha-editable.aloha-emptylink-plugin a[data-gentics-aloha-object-online='false'] { background-color: red; } From d4f9d1ac32914aa986683509d1dbd5c2fdb3f856 Mon Sep 17 00:00:00 2001 From: Philipp Zettl Date: Mon, 26 Aug 2019 14:13:28 +0200 Subject: [PATCH 2/2] SUP-8350: do some code-cleanup --- src/plugins/extra/emptylink/css/emptylink.css | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/extra/emptylink/css/emptylink.css b/src/plugins/extra/emptylink/css/emptylink.css index fb766ca284..2f7c58ae9a 100644 --- a/src/plugins/extra/emptylink/css/emptylink.css +++ b/src/plugins/extra/emptylink/css/emptylink.css @@ -1,18 +1,18 @@ /* mark all anchor elements without name and href attribute */ .aloha-editable.aloha-emptylink-plugin a:not([name]):not([href]), - /* mark all anchor elements with empty href attribute (including '#') and the name and data-gentics-aloha-object-id attributes not set */ +/* mark all anchor elements with empty href attribute (including '#') and the name and data-gentics-aloha-object-id attributes not set */ .aloha-editable.aloha-emptylink-plugin a[href='#']:not([name]):not([data-gentics-aloha-object-id]), .aloha-editable.aloha-emptylink-plugin a[href='']:not([name]):not([data-gentics-aloha-object-id]), .aloha-editable.aloha-emptylink-plugin a[href='http://']:not([name]):not([data-gentics-aloha-object-id]), .aloha-editable.aloha-emptylink-plugin a[href='https://']:not([name]):not([data-gentics-aloha-object-id]), - /* mark all anchor elements with empty name attribute and the href attribute not set */ +/* mark all anchor elements with empty name attribute and the href attribute not set */ .aloha-editable.aloha-emptylink-plugin a[name='']:not([href]), - /* mark all anchor elements with empty href (including '#') and empty name attribute */ +/* mark all anchor elements with empty href (including '#') and empty name attribute */ .aloha-editable.aloha-emptylink-plugin a[href='#'][name=''], .aloha-editable.aloha-emptylink-plugin a[href='http://'][name=''], .aloha-editable.aloha-emptylink-plugin a[href='https://'][name=''], .aloha-editable.aloha-emptylink-plugin a[href=''][name=''], - /* mark all anchor elements that are marked to link to offline data-gentics-aloha-objects */ +/* mark all anchor elements that are marked to link to offline data-gentics-aloha-objects */ .aloha-editable.aloha-emptylink-plugin a[data-gentics-aloha-object-online='false'] { background-color: red; }