Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource cache and management #249

Open
iboB opened this issue Feb 12, 2025 · 2 comments
Open

Resource cache and management #249

iboB opened this issue Feb 12, 2025 · 2 comments
Assignees
@iboB

Comments

@iboB
Copy link
Member

iboB commented Feb 12, 2025 •
edited
Loading

Implement based on #250

This likely ties in with the system context idea in #231
@iboB iboB added rnd Research and development triage Still under assessment. May be delayed or cancelled labels Feb 12, 2025
@iboB iboB self-assigned this Feb 12, 2025
@iboB iboB removed rnd Research and development triage Still under assessment. May be delayed or cancelled labels Feb 12, 2025
@iboB iboB moved this from Todo to In Progress in Local SDK Beta Feb 12, 2025
@iboB iboB removed this from Local SDK Beta Feb 21, 2025
iboB added a commit that referenced this issue Feb 24, 2025
@iboB
feat(local): wip for resource manager, ref #249
d9c4e25
iboB added a commit that referenced this issue Feb 25, 2025
@iboB
feat(local): continue resource manager design, ref #249
2ba2ecf
iboB added a commit that referenced this issue Feb 25, 2025
@iboB
feat(local): more resource manager iterations, ref #249
bfafae8
iboB added a commit that referenced this issue Feb 25, 2025
@iboB
feat(local): more resource manager iterations, ref #249
292d3fc
iboB added a commit that referenced this issue Feb 26, 2025
@iboB
feat(local): continue resource manager design, ref #249
1236e58
iboB added a commit that referenced this issue Feb 26, 2025
@iboB
feat(local): more resource manager iterations, ref #249
9637722
iboB added a commit that referenced this issue Feb 26, 2025
@iboB
feat(local): simplify resource management, ref #249
3a45792
iboB added a commit that referenced this issue Feb 26, 2025
@iboB
feat(local): simplify resource management, ref #249
29e9336
iboB added a commit that referenced this issue Feb 26, 2025
@iboB
feat(local): simplify resource management, ref #249
8b6ee74
iboB added a commit that referenced this issue Feb 26, 2025
@iboB
feat(dummy): add resource manager, ref #249
edbdd73
iboB added a commit that referenced this issue Feb 26, 2025
@iboB
feat(local): simplify resource management, ref #249
7c04462
iboB added a commit that referenced this issue Feb 26, 2025
@iboB
feat(dummy): add resource manager, ref #249
cfacf26
@iboB
Copy link
Member Author

iboB commented Feb 26, 2025

As of this point we have a trivial resource manager. Moving this to another project to be properly taken care of.

@iboB iboB changed the title Add utils which can help with model management Resource cache and management Feb 28, 2025
iboB pushed a commit that referenced this issue Feb 28, 2025
@pminev @iboB
feat: make ResourceManager templated by the key, ref #249
0c05c27 
-- this is improving how it's used by clients
iboB added a commit that referenced this issue Feb 28, 2025
@iboB
fix(local): fix resource manager double resource creation, add commen…
ae1375b 
…ts, ref #249
iboB added a commit that referenced this issue Feb 28, 2025
@iboB
style(local): reduce some copy-paste, remove unused headers, fix file…
96b6720 
… names, ref #249
@iboB
Copy link
Member Author

iboB commented Feb 28, 2025

The current implementation does the optimistic out-of-lock creation. While this is ok for most scenarios, it is not ok for us. The problem is that the creation of a resource may fail precisely because the same one is currently being created.

To fix this we would need to add per-resource locks in the manager

pminev added a commit that referenced this issue Feb 28, 2025
@pminev
feat: make ResourceManager templated by the key, ref #249
cfc73e9 
-- this is improving how it's used by clients
pminev pushed a commit that referenced this issue Feb 28, 2025
@iboB @pminev
fix(local): fix resource manager double resource creation, add commen…
0c129f8 
…ts, ref #249
pminev pushed a commit that referenced this issue Feb 28, 2025
@iboB @pminev
style(local): reduce some copy-paste, remove unused headers, fix file…
18c30ed 
… names, ref #249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iboB iboB

Labels
None yet
Projects
Local SDK Beta
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iboB