-
Notifications
You must be signed in to change notification settings - Fork 21
(ol): Add basic types #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ol): Add basic types #1085
Conversation
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #1085 +/- ##
==========================================
- Coverage 74.65% 74.65% -0.01%
==========================================
Files 507 511 +4
Lines 42292 42825 +533
==========================================
+ Hits 31575 31970 +395
- Misses 10717 10855 +138
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 56 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Commit: 21f4763 SP1 Execution Results
|
1b57d85 to
8599d5f
Compare
8599d5f to
54ab8a0
Compare
|
I had previously moved the existing |
54ab8a0 to
eaaa266
Compare
c74ee19 to
a931eed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine so far. There might be a little bit of overlap with #1090 when I hope to merge that soon.
a931eed to
3970e20
Compare
d2284fd to
5df31ad
Compare
5df31ad to
8714b8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8714b8e
Description
Type of Change
Notes to Reviewers
Checklist
in the body of this PR.
Related Issues