Skip to content

Conversation

@bewakes
Copy link
Contributor

@bewakes bewakes commented Oct 8, 2025

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI
    in the body of this PR.

Related Issues

@bewakes bewakes requested review from a team as code owners October 8, 2025 08:43
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 250 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.65%. Comparing base (1c6f9b5) to head (8714b8e).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/ol/chain-types/src/block.rs 0.00% 116 Missing ⚠️
crates/ol/state-types/src/state.rs 0.00% 46 Missing ⚠️
crates/ol/chain-types/src/transaction.rs 0.00% 40 Missing ⚠️
crates/ol/chain-types/src/common.rs 0.00% 36 Missing ⚠️
crates/ol/chain-types/src/log.rs 0.00% 12 Missing ⚠️
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
- Coverage   74.65%   74.65%   -0.01%     
==========================================
  Files         507      511       +4     
  Lines       42292    42825     +533     
==========================================
+ Hits        31575    31970     +395     
- Misses      10717    10855     +138     
Flag Coverage Δ
functional 53.44% <ø> (+0.59%) ⬆️
unit 54.61% <0.00%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crates/acct-types/src/id.rs 0.00% <ø> (ø)
crates/ol/chain-types/src/log.rs 0.00% <0.00%> (ø)
crates/ol/chain-types/src/common.rs 0.00% <0.00%> (ø)
crates/ol/chain-types/src/transaction.rs 0.00% <0.00%> (ø)
crates/ol/state-types/src/state.rs 0.00% <0.00%> (ø)
crates/ol/chain-types/src/block.rs 0.00% <0.00%> (ø)

... and 56 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Commit: 21f4763

SP1 Execution Results

program cycles success
EVM EE STF 1,172,528
CL STF 330,723
Checkpoint 2,422

@bewakes bewakes requested a review from a team as a code owner October 10, 2025 11:11
@bewakes bewakes requested review from delbonis and storopoli October 10, 2025 11:28
@bewakes
Copy link
Contributor Author

bewakes commented Oct 10, 2025

I had previously moved the existing ol-chain-types which contains types relating to TN1 into ol/chain-types. I've now correctly defined chain types from the spec.

@bewakes bewakes requested a review from delbonis October 13, 2025 06:22
Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine so far. There might be a little bit of overlap with #1090 when I hope to merge that soon.

@bewakes bewakes requested a review from delbonis October 15, 2025 06:02
@bewakes bewakes force-pushed the STR-1737-ol-types branch 2 times, most recently from d2284fd to 5df31ad Compare October 15, 2025 09:46
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8714b8e

@storopoli storopoli enabled auto-merge October 15, 2025 15:49
@storopoli storopoli added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit 8d35d9b Oct 15, 2025
28 of 30 checks passed
@storopoli storopoli deleted the STR-1737-ol-types branch October 15, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants