Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-11813-deploy-tech-docs-to-github-pages #934

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

rfisher-gds
Copy link
Contributor

Context

We want to serve tech-docs from Github Pages rather than PAAS.

Changes proposed in this pull request

Actions workflow to build and deploy static pages.

Guidance to review

@rfisher-gds rfisher-gds marked this pull request as ready for review November 15, 2023 11:40
Copy link
Contributor

@jfharden jfharden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small but important thing to address

.github/workflows/static.yml Show resolved Hide resolved
@rfisher-gds rfisher-gds force-pushed the PP-11813-deploy-tech-docs-to-github-pages branch from 494f54d to 9ca4e00 Compare November 15, 2023 13:41
@jfharden
Copy link
Contributor

Approved knowing we still need to setup GitHub Pages and it's likely to fail on merge, but that we will enable it after then

@rfisher-gds rfisher-gds merged commit 4e30451 into master Nov 15, 2023
5 checks passed
@rfisher-gds rfisher-gds deleted the PP-11813-deploy-tech-docs-to-github-pages branch November 15, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants