Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-11369: Adds information about webhook callback URL restrictions #943

Merged
merged 4 commits into from
Dec 18, 2023
Merged

PP-11369: Adds information about webhook callback URL restrictions #943

merged 4 commits into from
Dec 18, 2023

Conversation

NathanD-GDS
Copy link
Contributor

Context

Our documentation doesn't mention some of the restrictions we have on callback URLs for webhooks.

Changes proposed in this pull request

This PR clarifies that (from the JIRA ticket):

  • test webhook callback URLs have no domain restrictions
  • live webhook callback URLs must have a domain that ends in .gov.uk
  • a service can request a domain be allowed for live webhook callback URLs by emailing support
  • we will only allow domains that exclusively belong to the service or its parent organisation
  • even we decide to allow a domain, it will not be added immediately

@NathanD-GDS NathanD-GDS changed the title Adds information about webhook callback URL restrictions PP-11369: Adds information about webhook callback URL restrictions Dec 18, 2023
elenaschwan
elenaschwan reviewed Dec 18, 2023
View reviewed changes
Copy link

@elenaschwan elenaschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

alexbishop1
alexbishop1 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@alexbishop1 alexbishop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@NathanD-GDS NathanD-GDS merged commit 5e4d816 into master Dec 18, 2023
2 checks passed
@NathanD-GDS NathanD-GDS deleted the PP11369webhookURLs branch December 18, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenaschwan elenaschwan elenaschwan left review comments

@alexbishop1 alexbishop1 alexbishop1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NathanD-GDS @alexbishop1 @elenaschwan