-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A couple more code reviews #6
Comments
Additionally, episode 13's paginator should be done with a d.py extension |
Hi, I do remember you. Thank you. In terms of pep-8 I agree they are a bit long and it would've been clearer to split them up, it was just never that important to me. I'll start to do this though, thanks. For the invite_delete issue, that's a good point, I never knew that, thank you. Other Comments:
|
Finally for the paginators, I do know of that but I wanted to show some logic behind it. I do agree that it would be better though. |
Hey, don't know if you remember me from the last time I criticized your code, but I have a few more comments.
This is all for the invite tracking code.
First off, I would like to say that this was a large improvement from last time, but there are a few issues
The way you compare datetimes is bad.
strftiming then splitting is just- not needed, datetimes can be subtracted
for example
pep-8
The line lengths here are a bit long, especially the sql statements, you can split it like:
Logic Issues
Discord does not dispatch invite_delete for expired invites, which will be an issue for this. You might want a task.loop to continuously poll the invites
Other comments
The text was updated successfully, but these errors were encountered: