Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock Globus client should not inherit from real globus client #27

Closed
dylanmcreynolds opened this issue Sep 20, 2024 · 2 comments
Closed
Assignees

Comments

@dylanmcreynolds
Copy link
Contributor

class MockGlobusComputeClient(Client):

davramov added a commit to davramov/splash_flows_globus that referenced this issue Oct 2, 2024
@dylanmcreynolds
Copy link
Contributor Author

@davramov can you address this?

@davramov
Copy link
Contributor

davramov commented Oct 7, 2024

I have addressed this issue in my PR: #29

dylanmcreynolds pushed a commit that referenced this issue Oct 7, 2024
…us_flow.py, fix for issue #27 (#29)

- Updated `tiff_to_zarr.py` to read pixelsize from the raw h5 file and convert to micrometer for the multiscales step.
- Updated `init_tiff_to_zarr_globus_flow.py` to account for the new change (passing in the h5 path to the flow) as well as automatically updating the Prefect Secret Block on the server with the latest `flow_id` and `func_id` once the script runs. Side note: I removed the time import from the function definition because I was getting a cryptic "`time.run()` is not defined error" despite only calling `time.time()`.
- Updated instructions for running `check_globus_compute.py` in the docstring.

---
- To see the specific tasks where the Asana app for GitHub is being used, see below:
  - https://app.asana.com/0/0/1208451498137898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants