Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Priority" variable to ”EliteAttack.talk" #100

Open
uchiki opened this issue Mar 5, 2021 · 7 comments
Open

Add "Priority" variable to ”EliteAttack.talk" #100

uchiki opened this issue Mar 5, 2021 · 7 comments
Labels
EDDI enhancement New feature or request
Milestone

Comments

@uchiki
Copy link

uchiki commented Mar 5, 2021

Sometimes I want to use "EliteAttack.talk" with higher priority.
It would be nice to be able to send a "Priority" variable to EDDI when additionally specified.

@alterNERDtive
Copy link
Owner

Can you explain what you’re trying to do?

@uchiki
Copy link
Author

uchiki commented Mar 6, 2021

For example, if you want to give priority to "Jump primed." Of "Jump" or "Cruise" command over Speech Responder of EDDI, set "Priority" which is a variable of "say" command of EDDI to "EliteAttack.talk".
You can easily do it if you can use it from.

This is an example with the default value set to 4.
R030307

@alterNERDtive
Copy link
Owner

So you want me to set priority for TTS my stuff does?

@uchiki
Copy link
Author

uchiki commented Mar 6, 2021

Since the default of EDDI is 3, I want you to set the default of this profile to 2, which is higher than EDDI. Also, it would be nice to be able to add priorities at will.

Messages from this profile are often more important than those from EDDI, so prioritizing them will require less modification to the profile.

@alterNERDtive alterNERDtive added enhancement New feature or request EDDI labels Mar 8, 2021
@alterNERDtive
Copy link
Owner

alterNERDtive commented Mar 8, 2021

Messages from this profile are often more important than those from EDDI, so prioritizing them will require less modification to the profile.

I think you are misunderstanding how priorities work. Priority 1–4 only affects pending speech, aka everything after the current one. E.g. if 1 is running, then 2/2 is queued and you add a TTS invocation on prio 4, the current (prio 1) will finish, then the prio 4 one runs, then the prio 2 ones.

The only priorities with immediate effects are 0 (will always be immediately interrupted by anything prio ≥1) and 5 (will always cancel and running and pending speech and execute immediately).

Actually off the top of my head I’m not sure if 0 or 5 are highest, but you get the gist either way.

I’ve thought about adding priorities to TTS, but it’s not very high priority if I’m perfectly honest.

Also, it would be nice to be able to add priorities at will.

For your own stuff you can just use the say context with whatever priority you want. If you’re talking about being able to set priority for basically any TTS my profiles do, individually … yeah, no. Waaaaayyyyy not worth the effort, IMO.

@alterNERDtive
Copy link
Owner

I can definitely set a default priority to be slightly higher than EDDI’s default; but given it only affects pending speech I’m not sure if that’s what you want.

@uchiki
Copy link
Author

uchiki commented Mar 8, 2021

R030309

Actually, Priority 0 can be used.
In that case, the system message is also interrupted.

If multiple scripts send messages during an event, it makes sense to work on the pending ones.

For example, after a hyperspace jump, EDDI issues multiple messages, the message with a higher priority than EDDI (Priority 2) works as I expected.

@alterNERDtive alterNERDtive added this to the future milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EDDI enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants