Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek the current song command addition. #22

Open
driftywinds opened this issue Oct 5, 2021 · 13 comments
Open

Seek the current song command addition. #22

driftywinds opened this issue Oct 5, 2021 · 13 comments

Comments

@driftywinds
Copy link

I would love the functionality of being able to seek the currently playing song to a certain time stamp with a command like _seek.

@niloysikdar
Copy link
Contributor

Great, do you want to work on this @driftywinds ?

@driftywinds
Copy link
Author

Oh sorry, I'm not a coder, I thought we could put feature requests

@amanjha8100
Copy link
Owner

amanjha8100 commented Oct 5, 2021

Hey @driftywinds , thanks for the request. We have already thought about this and will be implementing this as soon as we are able to.
We are open to suggestions and you can always put up a feature request.

@amanjha8100 amanjha8100 changed the title Feature Request :- Seek the current song Seek the current song command addition. Oct 6, 2021
@EdgarACarneiro
Copy link
Contributor

Also, @amanjha8100, if you are not yet working this, I wouldn' mind picking it up either, seems a nice issue to better get to know the project 😊

@amanjha8100
Copy link
Owner

Hey @EdgarACarneiro , I have already completed the code for the issue, I am just waiting for the current song command to get completed, because in my implementation of the seek command, I would require that information. If you have some different approach feel free to discuss here then we can move forward, with whichever seems best.

My Approach
I would require the current song url somewhere stored , which I will reprocess with updated ffmpeg options.

@EdgarACarneiro
Copy link
Contributor

If you already have an approach it is fine, thanks for answering!

@amanjha8100
Copy link
Owner

Hey @EdgarACarneiro , you want to take this up, actually in India its the festive season and I am little busy. So if you want you can take this up!

@amanjha8100 amanjha8100 removed their assignment Oct 15, 2021
@amanjha8100 amanjha8100 added the help wanted Extra attention is needed label Oct 17, 2021
@amanjha8100
Copy link
Owner

@EdgarACarneiro

@EdgarACarneiro
Copy link
Contributor

Hey @amanjha8100 , I am currently unable to pick this one up, to much stuff on my hands on other projects :/

@amanjha8100
Copy link
Owner

No problem @EdgarACarneiro 😃

@driftywinds
Copy link
Author

Any updates on this?

@amanjha8100
Copy link
Owner

Hey @driftywinds, my initial try failed for this feature and with news on reopening of colleges in India., I haven't given this much of a thought. I will look into this and update you on this in next 2 days.

@driftywinds
Copy link
Author

Hey @driftywinds, my initial try failed for this feature and with news on reopening of colleges in India., I haven't given this much of a thought. I will look into this and update you on this in next 2 days.

Hey Aman, did you abandon this 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants