Skip to content

[BUG] excluded_attributes in config file is not being honored #302

@dbasunag

Description

@dbasunag

Bug Description

Based on readme, I created a config file:

excluded_attributes:
  - architecture_decisions
  - openapi_specs
  - test_coverage"

When I look at the report, all the excluded attributes are still showing up:

agentready assess . --config .agentready-config.yaml

Assessment complete!
  Score: 65.1/100 (Silver)
  Assessed: 24
  Skipped: 1
  Total: 25
  Duration: 3.1s

Assessment Results:
----------------------------------------------------------------------------------------------------
Test Name                           Test Result    Notes                         
----------------------------------------------------------------------------------------------------
architecture_decisions              ❌ FAIL         no ADR directory (need: ADR directory with deci...
branch_protection                   ⏭️ NOT_APPLICABLE Requires GitHub API integration for branch prot...
cicd_pipeline_visibility            ❌ FAIL         basic config (need: CI with best practices)
claude_md_file                      ✅ PASS         90/100                        
code_smells                         ✅ PASS         67/100                        
concise_documentation               ❌ FAIL         16 lines, 4 headings, 0 bullets (need: <500 lin...
container_setup                     ✅ PASS         60/100                        
conventional_commits                ❌ FAIL         not configured (need: configured)
cyclomatic_complexity               ✅ PASS         100/100                       
dependency_security                 ❌ FAIL         Security tools configured: detect-secrets, gitl...
file_size_limits                    ❌ FAIL         2 huge, 20 large out of 374 (need: <5% files >5...
gitignore_completeness              ✅ PASS         83/100                        
inline_documentation                ❌ FAIL         46.8% (need: ≥80%)            
issue_pr_templates                  ❌ FAIL         PR:False, Issues:0 (need: PR template + ≥2 issu...
lock_files                          ✅ PASS         100/100                       
one_command_setup                   ❌ FAIL         multi-step setup (need: single command)
openapi_specs                       ❌ FAIL         no OpenAPI spec (need: OpenAPI 3.x spec present)
precommit_hooks                     ✅ PASS         100/100                       
readme_structure                    ❌ FAIL         2/3 sections (need: 3/3 sections)
semantic_naming                     ✅ PASS         100/100                       
separation_of_concerns              ❌ FAIL         organization:100, cohesion:84, naming:0 (need: ...
standard_layout                     ❌ FAIL         1/2 directories (need: 2/2 directories)
structured_logging                  ❌ FAIL         not configured (need: structured logging library)
test_coverage                       ❌ FAIL         not configured (need: configured with >80% thre...
type_annotations                    ✅ PASS         100/100                       
----------------------------------------------------------------------------------------------------

Reports generated:
  JSON: .agentready/assessment-20260218-143914.json
  HTML: .agentready/report-20260218-143914.html
  Markdown: .agentready/report-20260218-143914.md
dbasunag@dbasunag-mac opendatahub-tests % 

A clear and concise description of what the bug is.
I installed agenready using
uv tool install --from git+https://github.com/ambient-code/agentready agentready
Created a config file to exclude a few attributes from the assessment.

To Reproduce

Steps to reproduce the behavior:

  1. Create a config file as above mentioned example
  2. Run the asses comment passing the same config file and check the result
  3. If I pass an invalid id in the config, it does not error out either

Expected Behavior

If invalid attributes are present in the config file, I should receive a clear error message indicating the problematic id.
All the excluded_attributes should be removed from assesment

Actual Behavior

None of the excluded_attributes were omitted.

A clear and concise description of what actually happened.

Environment

  • OS: macOS 26.2
  • Version: [e.g. 1.0.0]
  • Python Version: 3.14

Additional Context

Add any other context about the problem here. Include screenshots if applicable.

Possible Solution

If you have suggestions on how to fix the bug, please describe them here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingreleased

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions