Skip to content

Commit 39e9055

Browse files
authored
Fix Prettier formatting issues in admin dashboard code (#30)
Ran prettier --write on all files to fix formatting issues that were causing CI failures. This ensures code style consistency across the codebase. Fixed files: - app/admin/index.tsx - constants/AdminMetrics.ts - services/monitoring/sentry.ts - specs/002-admin-stats-dashboard/*.md
1 parent 2e5f0d7 commit 39e9055

10 files changed

Lines changed: 291 additions & 146 deletions

File tree

app/admin/index.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,7 @@ export default function OverviewDashboard() {
5656
/>
5757
<View style={styles.row}>
5858
<View style={styles.halfCard}>
59-
<MetricCard
60-
label="Web"
61-
value={data?.metrics.activeUsers.web ?? 0}
62-
subtitle="users"
63-
/>
59+
<MetricCard label="Web" value={data?.metrics.activeUsers.web ?? 0} subtitle="users" />
6460
</View>
6561
<View style={styles.halfCard}>
6662
<MetricCard

constants/AdminMetrics.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,8 @@ export const ADMIN_METRICS = {
102102
// Type Exports for Constants
103103
// ============================================================================
104104

105-
export type ChartColor = (typeof ADMIN_METRICS.CHART_COLORS)[keyof typeof ADMIN_METRICS.CHART_COLORS]
106-
export type StatusColor = (typeof ADMIN_METRICS.STATUS_COLORS)[keyof typeof ADMIN_METRICS.STATUS_COLORS]
105+
export type ChartColor =
106+
(typeof ADMIN_METRICS.CHART_COLORS)[keyof typeof ADMIN_METRICS.CHART_COLORS]
107+
export type StatusColor =
108+
(typeof ADMIN_METRICS.STATUS_COLORS)[keyof typeof ADMIN_METRICS.STATUS_COLORS]
107109
export type AdminEndpoint = (typeof ADMIN_METRICS.ENDPOINTS)[keyof typeof ADMIN_METRICS.ENDPOINTS]

services/monitoring/sentry.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,15 @@ export function captureMessage(
152152
* Start a performance transaction span
153153
*/
154154
export function startSpan(name: string, op: string) {
155-
return Sentry.startSpan({
156-
name,
157-
op,
158-
}, () => {
159-
// Span callback - operations tracked here
160-
})
155+
return Sentry.startSpan(
156+
{
157+
name,
158+
op,
159+
},
160+
() => {
161+
// Span callback - operations tracked here
162+
}
163+
)
161164
}
162165

163166
/**

specs/002-admin-stats-dashboard/checklists/requirements.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,14 @@ All checklist items are complete. The specification is ready to proceed to `/spe
3636
### Validation Details
3737

3838
**Content Quality**: ✅ PASS
39+
3940
- Specification focuses on WHAT users need (admin statistics dashboards) and WHY (operational monitoring, user engagement tracking, platform insights)
4041
- No mention of specific technologies like React, TypeScript, or Recharts in the specification itself
4142
- Written in plain language that non-technical stakeholders can understand
4243
- All mandatory sections (User Scenarios, Requirements, Success Criteria) are completed
4344

4445
**Requirement Completeness**: ✅ PASS
46+
4547
- No [NEEDS CLARIFICATION] markers present
4648
- All 42 functional requirements are specific and testable (e.g., "System MUST display active user counts separated by platform")
4749
- Success criteria are quantifiable (e.g., "Dashboard loads within 2 seconds", "95% platform detection accuracy")
@@ -51,6 +53,7 @@ All checklist items are complete. The specification is ready to proceed to `/spe
5153
- Dependencies on PostHog and Sentry for analytics are clearly stated
5254

5355
**Feature Readiness**: ✅ PASS
56+
5457
- Each functional requirement traces back to user stories and acceptance scenarios
5558
- User scenarios cover all primary flows: system health monitoring (P1), Golden Signals (P1), engagement tracking (P2), platform comparison (P2), navigation (P1), responsive design (P2)
5659
- Success criteria measure actual user outcomes (load time, accuracy, accessibility) rather than implementation details

0 commit comments

Comments
 (0)