Skip to content

fix(runner): add timestamps to Gemini CLI messages in UI#892

Merged
Gkrumbach07 merged 1 commit intomainfrom
fix/gemini-timestamps-52261
Mar 13, 2026
Merged

fix(runner): add timestamps to Gemini CLI messages in UI#892
Gkrumbach07 merged 1 commit intomainfrom
fix/gemini-timestamps-52261

Conversation

@Gkrumbach07
Copy link
Contributor

@Gkrumbach07 Gkrumbach07 commented Mar 12, 2026

Summary

  • Pass event timestamps from Gemini CLI NDJSON to AguiAssistantMessage objects
  • Converts ISO timestamps to milliseconds for AG-UI compatibility
  • Adds timestamps to TextMessageStartEvent for streaming events

Test plan

  • Unit tests pass (13/13 Gemini adapter tests)
  • Lints pass (ruff check + ruff format)
  • Manual test: start Gemini session, verify timestamps appear

Fixes: RHOAIENG-52261

Jira: RHOAIENG-52261

The Gemini CLI adapter was not passing event timestamps when creating
AguiAssistantMessage objects, causing the UI to show no timestamps
for Gemini sessions. Now converts ISO timestamps to epoch milliseconds
and passes them to both streaming events and snapshot messages.

Fixes: RHOAIENG-52261

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

Warning

Rate limit exceeded

@Gkrumbach07 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 28 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3409c88d-43a5-4036-a5e4-80adfddb8676

📥 Commits

Reviewing files that changed from the base of the PR and between 538ccbd and e7c2821.

📒 Files selected for processing (1)
  • components/runners/ambient-runner/ag_ui_gemini_cli/adapter.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/gemini-timestamps-52261
📝 Coding Plan for PR comments
  • Generate coding plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ambient-code
Copy link
Contributor

ambient-code bot commented Mar 12, 2026

🤖 PR Fixer Report

✅ Analysis Complete

PR Status: Ready to merge (pending E2E test re-run)

📋 What I Checked

  1. Code Review - Ran /simplify to review for reuse, quality, and efficiency

    • No duplicate code found
    • Timestamp handling is correct and efficient
    • Changes are focused and follow existing patterns
  2. Merge Conflicts - None (PR is mergeable)

  3. Reviewer Comments - None to address (only CodeRabbit rate limit warning)

  4. ⚠️ CI Status

    • ✅ Ambient Runner Tests: PASSED (13/13 Gemini adapter tests)
    • ✅ All lints: PASSED
    • ✅ All unit tests: PASSED
    • ❌ E2E Tests: FAILED (unrelated flake)

🔍 E2E Test Failure Analysis

The failing test is a flaky Cypress test unrelated to this PR's changes:

CypressError: cy.click() failed because the page updated while this command was executing.

Root cause: React re-rendering race condition in the frontend test suite (element detached from DOM during click)

Why it's not related to this PR:

  • This PR only modifies Python code (ag_ui_gemini_cli/adapter.py)
  • The failure is in a frontend Cypress test for session management UI
  • The error indicates a timing issue in the test itself, not a regression from timestamp changes

💡 Recommendation

Re-run the E2E Tests workflow - The failure is a known flake. The code changes are correct and all relevant tests pass.


Generated by Claude Code PR Fixer

@Gkrumbach07 Gkrumbach07 merged commit 12ad547 into main Mar 13, 2026
27 of 28 checks passed
@Gkrumbach07 Gkrumbach07 deleted the fix/gemini-timestamps-52261 branch March 13, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant