Skip to content

Commit dc3df2f

Browse files
authored
Add in a comment explaining where Python3::Interpreter comes from. (#510)
This is a compromise between doing the very correct thing (find_package(Python3) in ament_python_install_packge), and not changing things unnecessarily. Signed-off-by: Chris Lalancette <[email protected]>
1 parent 6b310f5 commit dc3df2f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

ament_cmake_python/cmake/ament_python_install_package.cmake

+3
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@ setup(
136136
endif()
137137
endif()
138138

139+
# Technically, we should call find_package(Python3) first to ensure that Python3::Interpreter
140+
# is available. But we skip this here because this macro requires ament_cmake, and ament_cmake
141+
# calls find_package(Python3) for us.
139142
get_executable_path(python_interpreter Python3::Interpreter BUILD)
140143

141144
add_custom_target(

0 commit comments

Comments
 (0)