Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(*): add one app debug port to runtime and expose #1101

Closed
wants to merge 1 commit into from

Conversation

drewcur
Copy link

@drewcur drewcur commented Aug 30, 2023

Acknowledge the debugging port initially added in one-app-runner and expose in the Dockerfile to access.

Description

To fully permit the use-debug feature to work, first acknowledge the env var setting to set the foundation and second, expose the port in the Dockerfile so it can be used when containerized.

Motivation and Context

Currently, the use-debug feature doesn't work because the port isn't expose

How Has This Been Tested?

See comments.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Should be able to connect the node debugger through the Docker container.

Acknowledge the debugging port initially added in one-app-runner and expose in the Dockerfile to access.
@drewcur
Copy link
Author

drewcur commented Aug 30, 2023

Still working on trying to build a local docker image, would it be a requirement to have tested it locally? Is there any other way I can validate these changes?

@JAdshead
Copy link
Contributor

JAdshead commented Sep 6, 2023

I believe that the changes to americanexpress/one-app-cli#559 should be enough to have this enabled.

@JAdshead
Copy link
Contributor

JAdshead commented Sep 8, 2023

closing for americanexpress/one-app-cli#559

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants