Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

DX enhancements - quieter logging on startup and polling, clickable URL in console #1371

Closed
wants to merge 2 commits into from

Conversation

agorskiy12
Copy link

@agorskiy12 agorskiy12 commented Apr 8, 2024

Description

when running one-app in node.env = 'development'

  • logging is cleaner on startup
  • hiding messages about bundle sizes unless they are critical
  • hiding messages about what ports the app is launching on
  • hiding messages about module map polling, unless something goes wrong
  • offer a clickable URL to the UI project in the command line

Motivation and Context

How Has This Been Tested?

unit tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@agorskiy12 agorskiy12 requested review from a team as code owners April 8, 2024 19:03
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ agorskiy12
❌ agorski


agorski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Size Change: 0 B

Total Size: 735 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 187 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 124 kB

compressed-size-action

@agorskiy12 agorskiy12 marked this pull request as draft April 8, 2024 19:37
@agorskiy12 agorskiy12 closed this Apr 8, 2024
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feat/dx-log branch May 3, 2024 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants