This repository has been archived by the owner on May 3, 2024. It is now read-only.
fix(server): remove npm and yarn from the production image #1382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove npm, npx, yarn, corepack, and their
node_modules
directories from the production image artifact.Upsides
Why we should not do this
npm serve-module <module-path>
will not work; not an issue in production but will be an issue for anyone using the production image with @americanexpress/one-app-runnerremoving files adds to the image size: similar to a git diff, the difference is stored.this must have changed, measuring this on my machine with dive and docker history I see the layer size being 0 BMotivation and Context
Ship as little as possible to production to minimize attack surface area (unlikely to contribute to an exploit, but computers are complex enough to make that risk not zero).
How Has This Been Tested?
PR checks
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
serving modules with npm (as @americanexpress/one-app-runner does) would not work anymore (explained above)