Admin Approval

[amina69]

Dont add anything new to the schema

📋 Description

Create endpoints for admins to approve or reject adoption requests. When approved, the pet status should update and (optionally) trigger escrow creation. When rejected, the pet returns to available status.

🎯 Context

After users submit adoption requests (#12) and admins can view them (#13), admins need the ability to make decisions. Approval moves the adoption forward (potentially creating blockchain escrow), while rejection frees the pet for other adopters.

📝 What You'll Build

Two Admin Endpoints

1. PATCH /adoptions/:id/approve - Approve a request

• Changes adoption status: PENDING → APPROVED
• Changes pet status: PENDING → AVAILABLE (or keeps PENDING for escrow)
• Optional: Triggers escrow creation (Phase 2)
• Returns updated adoption

2. PATCH /adoptions/:id/reject - Reject a request

• Changes adoption status: PENDING → REJECTED
• Changes pet status: PENDING → AVAILABLE
• Optional: Accepts rejection reason
• Returns updated adoption

What Happens on Approval

1. Validate adoption exists and is PENDING
2. Update adoption status to APPROVED
3. Update approvedAt timestamp
4. Future: Trigger escrow creation
5. Future: Send notification to adopter
6. Return updated adoption

What Happens on Rejection

1. Validate adoption exists and is PENDING
2. Update adoption status to REJECTED
3. Update pet status to AVAILABLE (free for others)
4. Optional: Store rejection reason/notes
5. Future: Send notification to adopter
6. Return updated adoption

🔧 Implementation Checklist

Files to Create/Modify

• src/adoption/adoption.controller.ts - Add approve/reject endpoints
• src/adoption/adoption.service.ts - Add approve/reject methods
• src/adoption/dto/reject-adoption.dto.ts - Optional rejection reason DTO
• src/pets/pets.service.ts - May need to update pet status
• Update Swagger documentation
• Add unit tests for both scenarios

What to Build

Approve Method:

• Accept adoptionId and adminUserId
• Verify adoption exists and status is PENDING
• Update adoption status to APPROVED
• Set approvedAt timestamp to now
• Return updated adoption with pet and user data

Reject Method:

• Accept adoptionId, adminUserId, and optional reason
• Verify adoption exists and status is PENDING
• Update adoption status to REJECTED
• Update pet status back to AVAILABLE
• Store rejection reason in notes field
• Return updated adoption

Validation:

• Only PENDING adoptions can be approved/rejected
• Only ADMIN role can perform these actions
• Adoption must exist (404 if not found)
• Pet must exist and be linked to adoption

Authorization:

• Both endpoints require ADMIN role
• Apply JwtAuthGuard + RolesGuard
• Use @roles('ADMIN') decorator

✅ Acceptance Criteria

• PATCH /adoptions/:id/approve endpoint exists
• PATCH /adoptions/:id/reject endpoint exists
• Both endpoints require ADMIN role
• Only PENDING adoptions can be approved
• Only PENDING adoptions can be rejected
• Approval updates adoption status to APPROVED
• Approval sets approvedAt timestamp
• Rejection updates adoption status to REJECTED
• Rejection updates pet status to AVAILABLE
• Rejection can include optional reason/notes
• Returns 404 if adoption not found
• Returns 400 if adoption not PENDING
• Returns 403 for non-admin users

🧪 How to Test

Setup:

1. Create ADMIN user
2. Create SHELTER user
3. Create regular USER
4. Shelter creates a pet
5. User submits adoption request (status: PENDING, pet: PENDING)

Test Approval Flow:

1. Admin approves adoption:

   • Login as ADMIN
   • PATCH /adoptions/123/approve
   • Response: 200 OK ✅
   • Adoption status: APPROVED
   • approvedAt: Current timestamp
   • Pet status: PENDING (ready for escrow)

2. Non-admin tries to approve:

   • Login as regular USER or SHELTER
   • PATCH /adoptions/123/approve
   • Response: 403 Forbidden ❌

3. Approve already approved:

   • PATCH /adoptions/123/approve (already APPROVED)
   • Response: 400 Bad Request ❌
   • Error: "Adoption is not pending"

4. Approve non-existent:

   • PATCH /adoptions/999/approve
   • Response: 404 Not Found ❌

Test Rejection Flow:

1. Admin rejects adoption:

   • Create new PENDING adoption
   • Login as ADMIN
   • PATCH /adoptions/456/reject
   • Body: { "reason": "Incomplete documentation" }
   • Response: 200 OK ✅
   • Adoption status: REJECTED
   • Pet status: AVAILABLE (freed for others)
   • notes: "Incomplete documentation"

2. Reject without reason:

   • PATCH /adoptions/456/reject
   • Body: {} (empty)
   • Should still work ✅

3. Non-admin tries to reject:

   • Login as regular USER
   • PATCH /adoptions/456/reject
   • Response: 403 Forbidden ❌

Edge Cases:

• Approve COMPLETED adoption → 400 Bad Request
• Reject REJECTED adoption → 400 Bad Request
• Approve CANCELLED adoption → 400 Bad Request

Suggested Approach:

1. Create approve endpoint in controller (ADMIN only)
2. Create reject endpoint in controller (ADMIN only)
3. Implement approve logic in service
4. Implement reject logic in service
5. Add status validation for both
6. Test with Postman/curl
7. Add unit tests
8. Update Swagger docs

Transaction Tip:
Use Prisma transactions for reject (updates adoption + pet) to ensure data consistency.

Approve Flow

Adoption: PENDING → APPROVED
Pet: PENDING → PENDING (awaiting escrow)

Reject Flow

Adoption: PENDING → REJECTED
Pet: PENDING → AVAILABLE (freed)

---

[drips-wave]

This issue has been added to the Stellar Wave Program and is worth 200 Points.

🧑‍💻 Interested in contributing? Apply to work on this issue on Drips Wave, earn points, and receive rewards.

Warning

Only applications submitted via the apply link above will be considered. Please do not apply by commenting on the issue or opening a PR directly.

🤠 Repo maintainers: You can manage this issue's Points and Complexity on your Maintainer Dashboard here. Please keep an eye on applications and respond quickly 💙

ℹ️ Learn more about Drips Wave

[Tola-byte]

@Tola-byte has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

I would like to do this.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Tola-byte to this issue.

[Babigdk]

@Babigdk has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Hi, let me work on this issue. I am a fullstack software developer with a solid background in backend development. I can do this in the next 25 hours

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Babigdk to this issue.

[Mkalbani]

@Mkalbani has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Hi maintainers. I'm a Web3 Fullstack dev. I've worked on a similar work. Would be done before the ETA. Thank you.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Mkalbani to this issue.

[Jayking40]

@Jayking40 has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

I'd like to work on this issue. I have strong experience with typescript, nestjs, react, prisma and can deliver a clean, well-tested implementation.

My approach:

1. Analyze the existing codebase and understand the current architecture
2. Implement the solution following project conventions and patterns
3. Write comprehensive tests and ensure all existing tests pass
4. Submit a clean PR with clear documentation

ETA: within 24 hours

I'm available to start immediately and can provide regular progress updates.

GitHub: @Jayking40

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Jayking40 to this issue.

[Eniola3321]

@Eniola3321 has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Please I will like to work on the issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Eniola3321 to this issue.

[emdevelopa]

@emdevelopa has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

I’d like to take this up and implement the admin approval/rejection endpoints with proper role-based access, adoption/pet status updates, validation for PENDING adoptions, and appropriate HTTP responses.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @emdevelopa to this issue.

[Codex723]

@Codex723 has applied to work on this issue as part of the Stellar Wave Program's 2nd wave.

Hello, I would like to be assigned this issue because I can deliver what you require in the span of 24hrs

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Codex723 to this issue.

[drips-wave]

Congratulations, @Babigdk! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on February 26, 2026.

🧑‍💻 @Babigdk: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are issued when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊