Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it awesome #7

Open
mika76 opened this issue Nov 20, 2020 · 6 comments
Open

Make it awesome #7

mika76 opened this issue Nov 20, 2020 · 6 comments

Comments

@mika76
Copy link

mika76 commented Nov 20, 2020

I think the whole term "awesome list" has become the de-facto standard name for lists like these so it might help people finding it if you name it so....

A list of C# Source Generators (not necessarily awesome), because I haven't found a good list yet.

I think it's awesome and you can always fake it till you make it 😉

@amis92
Copy link
Owner

amis92 commented Nov 20, 2020

I think for now I can just add the awesome-list tag for better search, but since I've included "awesome" in repo description, I think it should work for SEO - they won't really understand the "not necessarily" part, will they. :D

@ironcev
Copy link
Contributor

ironcev commented Nov 20, 2020

I agree the list is definitely awesome :-) @amis92 and I discussed this already here: ironcev/awesome-roslyn#16 (comment)

How do you see the future of the csharp-source-generators list? Should it stay in your opinion as a collection list and serve as a source for the awesome list? If so, we should link it from the awesome list at least. Or you think that having Source Generators on the awesome list serves the purpose? As mentioned, I see the benefits of both approaches.

Since awesome lists are made to be selections, and not collections we thought the best would be to pick the awesome stuff out and add it to the Source Generator section of the Awesome Roslyn list, here the @amis92 opinion: ironcev/awesome-roslyn#16 (comment)

I do mu best to closely follow @amis92 great work and take over generators that reached the certain level of maturity as well as articles and tutorials.

@AraHaan
Copy link
Contributor

AraHaan commented Jun 28, 2021

@ironcev you ok with adding my generator to that list as well too? #46

@ironcev
Copy link
Contributor

ironcev commented Jun 29, 2021

Hi @AraHaan, thanks for contributing the generator! I plan to take a closer look at the generators added recently to the source-generators list. There are quite some generators added which is great to see :-) But it will make it hard to choose a few to take over. In general I am trying to find some that somehow showcase something not seen in already added generators. E.g. you use Roslyn SyntaxFactory to create the code which is the way I would always prefere, while many generators work directly with string concatenation. Is it fin for you if I ping you back once I take a closer look at the other recently added generators?

@AraHaan
Copy link
Contributor

AraHaan commented Jun 29, 2021

Sure

@TwentyFourMinutes
Copy link

Hey @ironcev, I don't necessarily want to self advertise my library in any way, nor do I think it is yet worth to add it to this or a similar list, as it is currently not in a usable or production ready state. However, I am currently working on generating a full ORM with Source Generators and I am utilizing the SyntaxFactory API extensivly. I just want to say that I fully agree with you. Generating code with string concatenation is not just unreliable, but also error prone, unmaintainable and a pain in the butt to write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants