Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode theme #12

Open
topepo opened this issue Dec 11, 2023 · 4 comments
Open

Dark mode theme #12

topepo opened this issue Dec 11, 2023 · 4 comments
Labels

Comments

@topepo
Copy link
Contributor

topepo commented Dec 11, 2023

Although it won't affect images, we should have some css for this

@topepo
Copy link
Contributor Author

topepo commented Jun 17, 2024

  • ggplots
  • shinylive
  • algorithms
  • pre-made images
  • gt kableExtra tables
  • callout boxes
  • background color of inline code

Specific theme issues:

  • chapters/overfitting.html#fig-two-class-overfit
  • chapters/overfitting.html#fig-learn-rate-seq (use shinylive)
  • chapters/introduction.html#eq-log-linear
  • chapters/interactions-nonlinear.html#fig-ensemble-pdp

@topepo
Copy link
Contributor Author

topepo commented Jun 17, 2024

It looks like tables from kableExtra can do light/dark css with an extra option. Moving gt tables over to that package.

@topepo
Copy link
Contributor Author

topepo commented Jun 17, 2024

For shinylive, the thematic package handles it but you have to click on a button in Quarto and a button in the shiny app to switch light/dark 😢

topepo pushed a commit that referenced this issue Jun 29, 2024
@topepo
Copy link
Contributor Author

topepo commented Jun 29, 2024

The dark mode code should not reset all theme settings, such as the legend.position:

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant