Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic regression tests #3

Open
topepo opened this issue Nov 22, 2023 · 0 comments
Open

Add basic regression tests #3

topepo opened this issue Nov 22, 2023 · 0 comments

Comments

@topepo
Copy link
Contributor

topepo commented Nov 22, 2023

A few implementations, specifically torch and libsvm/kernlab, don't have good control over random number usage. Also, we have seen differences in results across intel and apple silicon chips (but that seems to be getting better).

We have some places where we programmatically write out results in-line. If the results change, our encoded conclusions might no longer be valid.

We can take a few key objects and save their results once their usage is finalized. Then we can use testthat to verify that those results are the same (or within some tolerance). Since the project is almost structured like an R package, this means that we can use devtools::test() to check for consistency of results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant