Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild-native-modules Warning: Arguments to path.resolve must be strings #23

Closed
Wortex17 opened this issue Mar 8, 2015 · 1 comment · Fixed by #30
Closed

rebuild-native-modules Warning: Arguments to path.resolve must be strings #23

Wortex17 opened this issue Mar 8, 2015 · 1 comment · Fixed by #30

Comments

@Wortex17
Copy link

Wortex17 commented Mar 8, 2015

As stated in #22, running grunt rebuild-native-modules (after a successfull grunt build-atom-shell) results in

>> Found existing node.js installation, skipping install to save time!
Warning: Arguments to path.resolve must be strings Use --force to continue.

for me

Running grunt -v --stack rebuild-native-modules gives:

>> Found existing node.js installation, skipping install to save time!
Warning: Arguments to path.resolve must be strings Use --force to continue.
TypeError: Arguments to path.resolve must be strings
    at Object.exports.resolve (path.js:116:15)
    at F:\PROJ\node_modules\grunt-build-atom-shell\tasks\build-atom-shell-task.coffee:164:23
    at tryCatcher (F:\PROJ\node_modules\grunt-build-atom-shell\node_modules\rx\dist\rx.js:568:29)
    at setDisposable (F:\PROJ\node_modules\grunt-build-atom-shell\node_modules\rx\dist\rx.js:4830:36)
    at AnonymousObservable.s [as _subscribe] (F:\PROJ\node_modules\grunt-build-atom-shell\node_modules\rx\dist\rx.js:4847:11)
    at AnonymousObservable.Rx.Observable.observableProto.subscribe.observableProto.forEach (F:\PROJ\node_modules\grunt-build-atom-shell\node_modules\rx\dist\rx.js:2138:19)
    at F:\PROJ\node_modules\grunt-build-atom-shell\node_modules\rx\dist\rx.js:1633:38
    at F:\PROJ\node_modules\grunt-build-atom-shell\node_modules\rx\dist\rx.js:1086:9
    at recursiveAction (F:\PROJ\node_modules\grunt-build-atom-shell\node_modules\rx\dist\rx.js:1030:9)
    at F:\PROJ\node_modules\grunt-build-atom-shell\node_modules\rx\dist\rx.js:1038:13

_(I substituted the full project path with _PROJ* for readibility)*

@Wortex17 Wortex17 changed the title Warning: Arguments to path.resolve must be strings rebuild-native-modules Warning: Arguments to path.resolve must be strings Mar 8, 2015
@maxkorp
Copy link
Contributor

maxkorp commented Apr 20, 2015

The call to generateNodeLib inside of rebuildNativeModules isn't passing the node-version, so it breaks. I'll make a PR in a second here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants