Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CMSIS,Examples,PeriphDrivers): Sync latest ME30 changes #1075

Merged
merged 226 commits into from
Sep 12, 2024
Merged

chore(CMSIS,Examples,PeriphDrivers): Sync latest ME30 changes #1075

merged 226 commits into from
Sep 12, 2024

Conversation

sihyung-maxim
Copy link
Contributor

Description

It has been awhile since the last time the feat/ME30 branch was synced up to main (May). Most people should be aware that the feat/ME30 contains the latest files, and the ME30 files in main have been out of date.

Some highlights:

  • Add I3C, Boost, RSTZ, Frequency Counter, MPC, SPC, and NSPC registers.
  • Add trustzone support to build system: memory definitions are done by build system.
  • Initial commit for MPC, SPC, and NSPC drivers (needs more testing).
  • CMSIS fixes and changes.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

Jake-Carter and others added 30 commits April 18, 2024 16:03
@Jake-Carter
Allow configuration of -mcpu for different archs
c691d2b
@Jake-Carter
Add starter/placeholder ME30 files
5061c3b
@sihyung-maxim
Initial commit for updated ME30 register files
98bc66d
@sihyung-maxim
Update copyrights
3befb13
@sihyung-maxim
Update LPCMP names
319d6dc
@sihyung-maxim
Initial passthrough for max32657.h
b2d3100
@sihyung-maxim
Update IVT for max32657.h
2cd2bb9
@sihyung-maxim
Fix TMR registers
4b81357
@sihyung-maxim
Fix copyright names and add SPC
64f15d3
@sihyung-maxim
Remove unsuppored peripherals from CMSIS
9417f4e
@Jake-Carter
Merge remote-tracking branch 'remotes/upstream/main' into feat/ME30
7ac0d96
@ozersa @Jake-Carter
Add MAX32657 in zephyr build system
609b7b7 
This commit enable MAX32657 zephyr support.

Signed-off-by: Sadik Ozer <[email protected]>
@ozersa @Jake-Carter
Update wrappers to cover MAX32657
5d26d28 
Signed-off-by: Sadik Ozer <[email protected]>
@lorne-maxim @Jake-Carter
feat(PeriphDrivers): Add PinMux tool supporting functions (#997)
b87895f 
Co-authored-by: lorne-maxim <[email protected]>
@lorne-maxim @sihyung-maxim @Jake-Carter
fix(Tools): Update Keil support for ECC enabled versions of the MAX32…
47408bb 
…675 (#1001)

Co-authored-by: lorne-maxim <[email protected]>
Co-authored-by: Sihyung Woo <[email protected]>
@Jake-Carter
Add MAX32657 peripheral interface files
3678f41 
These files are exact copy of MAX32655
Files will be updated in next sections, added here
to demonstrate delta clearly on next steps

Signed-off-by: Sadik Ozer <[email protected]>
@ozersa @Jake-Carter
Add MAX32657 peripheral source files
12429e5 
These files are exact copy of MAX32655
Files will be updated in next sections, added here
to demonstrate delta clearly on next steps

Signed-off-by: Sadik Ozer <[email protected]>
@Jake-Carter
Merge pull request #996 from analogdevicesinc/feat/add-MAX32657-Build
81d42d9 
feat(PeriphDrivers): Add max32657 basic files
@Jake-Carter
Set FPU 'fpv5-sp-d16' for ME30
c3a5362
@sihyung-maxim
Update register files to match appropriate IP
03a5c6a
@sihyung-maxim
Merge branch 'feat/ME30' of github.com:analogdevicesinc/msdk into fea…
189acd0 
…t/ME30
@sihyung-maxim
Re-add files that were accidentally removed
326905c
@sihyung-maxim
Remove ISO clock and set IPO to 50MHz
471a09c
@sihyung-maxim
Fix for linter
03b7c75
@sihyung-maxim
Fix copyright
77ce4ed
@sihyung-maxim
Update ICC, SPI, and remove unsupported register files
3927d4f
@sihyung-maxim
Remove unneeded SVD files
6b34f93
@sihyung-maxim
Fix INRO clock freq and move SPC into SYS
3b029ab
@sihyung-maxim
Add NSPC register
aa238cc
@Jake-Carter
Remove inclusion of lpgcr regs
01cda58
ozersa and others added 3 commits July 29, 2024 17:20
@ozersa
To flash section can be used
b3e8539 
Remove application flash section restriction from flash driver
Some section of flash can be used for storage purpose

Signed-off-by: Sadik Ozer <[email protected]>
@sihyung-maxim
Add MCR RST Register
710759b
@sihyung-maxim
Fix fetch script and add MCR_RST.rstz
ded2ee6
@ozersa
Copy link
Contributor

ozersa commented Aug 8, 2024 •
edited
Loading

As per of final register map, some field shall be removed from osc_ctrl register

https://github.com/analogdevicesinc/msdk/blob/feat/ME30/Libraries/CMSIS/Device/Maxim/MAX32657/Include/rtc_regs.h#L216

image

@ozersa
Copy link
Contributor

ozersa commented Aug 14, 2024

Could it be rebased onto main then merged if possible.

@ozersa ozersa requested a review from MaureenHelm August 14, 2024 15:41
@ozersa ozersa mentioned this pull request Aug 21, 2024
Merged
4 tasks
@ozersa
Copy link
Contributor

ozersa commented Sep 10, 2024

To peripheral driver and CMSIS files being merged, I copied them from this branch and fixed conflicts issues, created a new PR that just focus on peripheral drivers and CMSIS files. here: #1160
Please take a look when you get a chance.

@Jake-Carter Jake-Carter dismissed their stale review September 11, 2024 01:07

@ozersa @sihyung-maxim @ttmut merged main into feat/ME30. I still think my review comments should be addressed, but it's been a month and the changes are pretty significant. Let's merge this in now so it doesn't diverge further from main

@Jake-Carter Jake-Carter mentioned this pull request Sep 11, 2024
Closed
4 tasks
@github-actions github-actions bot added the Workflow Related to Workflow development label Sep 11, 2024
@Jake-Carter Jake-Carter merged commit 71ad374 into main Sep 12, 2024
8 of 9 checks passed
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 12, 2024
@actions-user
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1075
6974336
@Jake-Carter
Copy link
Contributor

@analogdevicesinc/msdk - all maintainers working on MAX32657 be advised feat/ME30 has been merged into main.

I will delete feat/ME30 on friday. Please rebase all future updates onto main

@ozersa
Copy link
Contributor

ozersa commented Sep 12, 2024

Please see hot fixes for build issues on zephyr side.
#1173

@ozersa ozersa mentioned this pull request Sep 13, 2024
Closed
ttmut pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Oct 31, 2024
@actions-user @ttmut
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1075
2042c1b
@ttmut ttmut mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozersa ozersa ozersa approved these changes

@Jake-Carter Jake-Carter Jake-Carter left review comments

@lorne-maxim lorne-maxim Awaiting requested review from lorne-maxim

@EricB-ADI EricB-ADI Awaiting requested review from EricB-ADI

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

Assignees
No one assigned
Labels
Register Change This issue or pull request involves a change to the MSDK registers. Tools This issue or pull request involves a change to the Tools Workflow Related to Workflow development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sihyung-maxim @ozersa @Jake-Carter @lorne-maxim @karaanil @EricB-ADI @BobbyCounts @hfakkiz @mertekren @ttmut