Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Examples): Add dedicated UART_DMA example to MAX32650, MAX32655, MAX32665, MAX32670, MAX32672, MAX32690, and MAX78000 #1115

Merged
merged 6 commits into from
Sep 23, 2024
Merged

feat(Examples): Add dedicated UART_DMA example to MAX32650, MAX32655, MAX32665, MAX32670, MAX32672, MAX32690, and MAX78000 #1115

merged 6 commits into from
Sep 23, 2024

Conversation

ozan956
Copy link
Contributor

@ozan956 ozan956 commented Aug 16, 2024

UART_DMA Example

Description

Due to the changes in DMA, UART examples are not working with DMA. This was stated both in the issues raised in the MSDK repository and in the tickets sent to us (Customer Support Team). So, @Jake-Carter and I developed a new example called UART_DMA.

The example has been added and tested for the following boards:

  • MAX32650
  • MAX32655
  • MAX32665
  • MAX32670
  • MAX32672
  • MAX32690
  • MAX78000

@github-actions github-actions bot added MAX32650 Related to the MAX32650 (ME10) MAX32655 Related to the MAX32655 (ME17) MAX32665 Related to the MAX32665 (ME14) MAX32670 Related to the MAX32670 (ME15) MAX32672 Related to the MAX32672 (ME21) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) labels Aug 16, 2024
@ozan956 ozan956 changed the title feat(Examples) : New example for UART with DMA feat(Examples): New example for UART with DMA Aug 16, 2024
@ozan956 ozan956 self-assigned this Aug 16, 2024
@Jake-Carter Jake-Carter linked an issue Aug 20, 2024 that may be closed by this pull request
MAX32672 UART2 port does not work in UART Example Project #1106
Closed
@sihyung-maxim
Copy link
Contributor

/clang-format-run

@sihyung-maxim
Copy link
Contributor

Could you merge the latest UART changes from main into your fork? Some UART clock source fixes were recently made. Once you do, I can help verify the examples again.

@ozan956
Copy link
Contributor Author

ozan956 commented Aug 23, 2024

Could you merge the latest UART changes from main into your fork? Some UART clock source fixes were recently made. Once you do, I can help verify the examples again.

I have merged latest changes. @sihyung-maxim

sihyung-maxim
sihyung-maxim requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Just need to do a find+replace for the copyright titles.

Jake-Carter
Jake-Carter approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ozan956

FYI updated project files using latest MSDKGen (dbcc067) and updated copyrights (2adea94).

Jake-Carter
Jake-Carter reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably clean up the UART example as well to remove the DMA code and point customers to this instead

@ozan956 ozan956 requested a review from sihyung-maxim August 29, 2024 04:06
@sihyung-maxim sihyung-maxim changed the title feat(Examples): New example for UART with DMA feat(Examples): Add dedicated UART_DMA example to MAX32650, MAX32655, MAX32665, MAX32670, MAX32672, MAX32690, and MAX78000 Sep 23, 2024
@sihyung-maxim
Copy link
Contributor

Mouthful of a PR name

@sihyung-maxim sihyung-maxim merged commit 67ed311 into analogdevicesinc:main Sep 23, 2024
11 checks passed
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 23, 2024
@actions-user
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1115
93e3051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Carter Jake-Carter Jake-Carter approved these changes

@sihyung-maxim sihyung-maxim sihyung-maxim approved these changes

@lorne-maxim lorne-maxim Awaiting requested review from lorne-maxim

Assignees

@ozan956 ozan956

Labels
MAX32650 Related to the MAX32650 (ME10) MAX32655 Related to the MAX32655 (ME17) MAX32665 Related to the MAX32665 (ME14) MAX32670 Related to the MAX32670 (ME15) MAX32672 Related to the MAX32672 (ME21) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAX32672 UART2 port does not work in UART Example Project
3 participants
@ozan956 @sihyung-maxim @Jake-Carter