feat(PeriphDrivers): Implement low power modes for MAX32657 #1317
+82
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added standby mode and SRAM retention. Unavailable features are removed. Signed-off-by: Tahsin Mutlugun <[email protected]>
Update wrap_max32_lp.h to accomodate the low power modes of MAX32657. Signed-off-by: Tahsin Mutlugun <[email protected]>
github-actions
bot
added
MAX32657
Thanks for the feedback. Could you be more specific? |
Comment on lines
+91
to
+106
| /** | ||
| * @brief Enable retention regulator | ||
| */ | ||
| void MXC_LP_RetentionRegEnable(void); | ||
|
|
||
| /** | ||
| * @brief Disable retention regulator | ||
| */ | ||
| void MXC_LP_RetentionRegDisable(void); | ||
|
|
||
| /** | ||
| * @brief Is the retention regulator enabled | ||
| * | ||
| * @return 1 = enabled 0 = disabled | ||
| */ | ||
| int MXC_LP_RetentionRegIsEnabled(void); |
There was a problem hiding this comment.
Put action verb at the beginning of the function name for tone to be consistent in the rest of the file.
/**
* @brief Enable retention regulator
*/
void MXC_LP_EnableRetentionReg(void);
/**
* @brief Disable retention regulator
*/
void MXC_LP_DisableRetentionReg(void);
There was a problem hiding this comment.
MXC_LP_RetentionRegIsEnabled is fine. Didn't mean to include that function in the review window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates MAX32657 low power API as listed below.