fix(PeriphDrivers): Issue #1293: MAX32670 I2C Driver causes a Double-Read

[dnguye14-adi]

Description

In the Master Transaction function, add a checking to return BUSY if the I2C bus is not ready.

[Brandon-Hurst]

Hello, as I mentioned in the issue #1293, I recommend changing the first while loop to an if statement. This will prevent the possibility of infinite loops if the I2C peripheral is busy / hanging. Returning an error indicating the I2C controller is busy is sufficient in this case, and a while loop should not be needed. I tested this as well and left screenshots in the issue linked.

I would propose changing this:

while(i2c->status & MXC_F_I2C_REVA_STATUS_BUSY) {}
// Wait until last transaction finished and bus ready

to this:

// If there is an active transaction, return a BUSY error
if (i2c->status & MXC_F_I2C_REVA_STATUS_BUSY) {
    return E_BUSY;
}

[Brandon-Hurst]

Hello, is there any response to my request above or info on when this change could be merged?

[sihyung-maxim]

Hello, as I mentioned in the issue #1293, I recommend changing the first while loop to an if statement. This will prevent the possibility of infinite loops if the I2C peripheral is busy / hanging. Returning an error indicating the I2C controller is busy is sufficient in this case, and a while loop should not be needed. I tested this as well and left screenshots in the issue linked.

I would propose changing this:

while(i2c->status & MXC_F_I2C_REVA_STATUS_BUSY) {}
// Wait until last transaction finished and bus ready

to this:

// If there is an active transaction, return a BUSY error
if (i2c->status & MXC_F_I2C_REVA_STATUS_BUSY) {
    return E_BUSY;
}

Sorry, I've been away from MSDK support for a while because of other pending tasks. I agree with this too; we should avoid an infinite loop without a timeout or any way to exit.

[AlbertFrancis07]

Hello, as I mentioned in the issue #1293, I recommend changing the first while loop to an if statement. This will prevent the possibility of infinite loops if the I2C peripheral is busy / hanging. Returning an error indicating the I2C controller is busy is sufficient in this case, and a while loop should not be needed. I tested this as well and left screenshots in the issue linked.

I would propose changing this:

while(i2c->status & MXC_F_I2C_REVA_STATUS_BUSY) {}
// Wait until last transaction finished and bus ready

to this:

// If there is an active transaction, return a BUSY error
if (i2c->status & MXC_F_I2C_REVA_STATUS_BUSY) {
    return E_BUSY;
}

I too faced the same Problem of I2C hanging in infinite loop due to sudden transaction , while interfacing MAX78000 with ADXL382 accelerometer and the above proposed solution of making I2C bus wait till end of transaction has helped me fix it.

[dnguye14-adi]

@AlbertFrancis07, you could also try with the solution not using the while-loop.