Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Documentation): Remove Misleading Doxygen Comment for I2C Init (Doesn't Set Speed) #782

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix(Documentation): Remove Misleading Doxygen Comment for I2C Init (Doesn't Set Speed) #782

merged 1 commit into from
Nov 2, 2023

Conversation

Jake-Carter
Copy link
Contributor

@Jake-Carter Jake-Carter commented Oct 25, 2023 •
edited
Loading

Description

Closes #752

None of our I2C init functions actually set the I2C frequency.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added MAX32520 Related to the MAX32520 (ES17) MAX32570 Related to the MAX32570 (ME13) MAX32650 Related to the MAX32650 (ME10) MAX32655 Related to the MAX32655 (ME17) MAX32660 Related to the MAX32660 (ME11) MAX32665 Related to the MAX32665 (ME14) MAX32670 Related to the MAX32670 (ME15) MAX32672 Related to the MAX32672 (ME21) MAX32675 Related to the MAX32675 (ME16) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87) MAX32662 Related to the MAX32662 (ME12) labels Oct 25, 2023
@sihyung-maxim
Copy link
Contributor

Merge from main, should fix the Verify Register/SVD workflow.

@Jake-Carter Jake-Carter merged commit 74042a9 into analogdevicesinc:main Nov 2, 2023
@Jake-Carter Jake-Carter deleted the fix/gh-752 branch November 2, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacob-Scheiffler Jacob-Scheiffler Jacob-Scheiffler approved these changes

@sihyung-maxim sihyung-maxim sihyung-maxim approved these changes

Assignees
No one assigned
Labels
MAX32520 Related to the MAX32520 (ES17) MAX32570 Related to the MAX32570 (ME13) MAX32650 Related to the MAX32650 (ME10) MAX32655 Related to the MAX32655 (ME17) MAX32660 Related to the MAX32660 (ME11) MAX32662 Related to the MAX32662 (ME12) MAX32665 Related to the MAX32665 (ME14) MAX32670 Related to the MAX32670 (ME15) MAX32672 Related to the MAX32672 (ME21) MAX32675 Related to the MAX32675 (ME16) MAX32680 Related to the MAX32680 (ME20) MAX32690 Related to the MAX32690 (ME18) MAX78000 Related to the MAX78000 (AI85) MAX78002 Related to the MAX78002 (AI87)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAX32660 misguiding comment in i2c.h
3 participants
@Jake-Carter @sihyung-maxim @Jacob-Scheiffler